Hide Forgot
Spec URL: https://github.com/FZUG/repo/blob/master/rpms/deepin_project/deepin-wm-switcher.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00501859-deepin-wm-switcher/deepin-wm-switcher-1.1.0-1.git8692ad3.fc25.src.rpm Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=17617894 Description: Window manager switcher for Deepin Fedora Account System Username: mosquito
SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00585991-deepin-wm-switcher/deepin-wm-switcher.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00585991-deepin-wm-switcher/deepin-wm-switcher-1.1.2-1.fc25.src.rpm Release 1.1.2
It would be better to include some additional info in %description about what this package actually *does*. The text from https://github.com/linuxdeepin/deepin-wm-switcher#deepin-wm-switcher would be OK, I think. Looks OK, but #1421058 needs to be done first to meaningfully review this.
#1421058 is done. let's go review it. @Zbigniew Jędrzejewski-Szmek
https://koji.fedoraproject.org/koji/taskinfo?taskID=22368478
+ package name is OK + license is acceptable for Fedora (GPLv3) + license is specified correctly + package builds in mock + BuildRequires / Requires / Provides look OK + latest version + fedora-review finds no issues + rpmlint output is OK (only some grumbling about missing man pages and documentation) + no scriptlets are necessary Package is APPROVED. I didn't test it, but the packaging is OK.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-wm-switcher
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.