Bug 1421858

Summary:	Review Request: flannel-container - system container for flannel
Product:	[Fedora] Fedora	Reporter:	Yu Qi Zhang <jzehrarnyg>
Component:	Package Review	Assignee:	Tomas Tomecek <ttomecek>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	container-review, package-review, ttomecek
Target Milestone:	---	Flags:	ttomecek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-02-24 17:08:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	177841

Description Yu Qi Zhang 2017-02-13 21:17:27 UTC

Dockerfile URL: https://github.com/projectatomic/atomic-system-containers/blob/master/flannel/Dockerfile

Source: https://github.com/projectatomic/atomic-system-containers/tree/master/flannel

Description: 
flannel is an etcd driven virtual network that gives a subnet to each host for use with container runtimes. This package is intended to be ran as a system container.

More information on system containers here: http://www.projectatomic.io/blog/2016/09/intro-to-system-containers/
A quick guide: https://github.com/yuqi-zhang/atomic-system-containers-quickstart

Fedora Account System Username: yzhang

Comment 1 Tomas Tomecek 2017-02-15 13:02:01 UTC

https://github.com/projectatomic/atomic-system-containers/blob/master/flannel/Dockerfile#L1
> FROM fedora

Please pin to a specific fedora version, as described in guidelines.

https://fedoraproject.org/wiki/Container:Guidelines#CMD_.2F_ENTRYPOINT


https://github.com/projectatomic/atomic-system-containers/blob/master/flannel/Dockerfile#L5
> ENV container=docker
> ENV FLANNELD_ETCD_ENDPOINTS="http://127.0.0.1:2379"
> ...

Chain these, so they are within a single instruction. LABEL on line 10 does it right.


It would also be great to have some documentation inside container how should one use it.


Anyway, well done. I haven't found any serious issues.

Comment 2 Yu Qi Zhang 2017-02-16 20:32:54 UTC

Thanks! The fixes to the above highlighted issues have been merged. PTAL.

Comment 3 Tomas Tomecek 2017-02-17 13:33:37 UTC

LGTM

Comment 4 container-review 2017-02-21 23:27:20 UTC

Sponsored.

Comment 5 Gwyn Ciesla 2017-02-22 16:56:11 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/docker/flannel