Dockerfile URL: https://github.com/projectatomic/atomic-system-containers/blob/master/flannel/Dockerfile Source: https://github.com/projectatomic/atomic-system-containers/tree/master/flannel Description: flannel is an etcd driven virtual network that gives a subnet to each host for use with container runtimes. This package is intended to be ran as a system container. More information on system containers here: http://www.projectatomic.io/blog/2016/09/intro-to-system-containers/ A quick guide: https://github.com/yuqi-zhang/atomic-system-containers-quickstart Fedora Account System Username: yzhang
https://github.com/projectatomic/atomic-system-containers/blob/master/flannel/Dockerfile#L1 > FROM fedora Please pin to a specific fedora version, as described in guidelines. https://fedoraproject.org/wiki/Container:Guidelines#CMD_.2F_ENTRYPOINT https://github.com/projectatomic/atomic-system-containers/blob/master/flannel/Dockerfile#L5 > ENV container=docker > ENV FLANNELD_ETCD_ENDPOINTS="http://127.0.0.1:2379" > ... Chain these, so they are within a single instruction. LABEL on line 10 does it right. It would also be great to have some documentation inside container how should one use it. Anyway, well done. I haven't found any serious issues.
Thanks! The fixes to the above highlighted issues have been merged. PTAL.
LGTM
Sponsored.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/docker/flannel