Bug 1421951
| Summary: | VMware : Failure in snapshot revert | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Prasad Mukhedkar <pmukhedk> | |
| Component: | UI - OPS | Assignee: | Brian McLaughlin <bmclaugh> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Aziza Karol <akarol> | |
| Severity: | high | Docs Contact: | ||
| Priority: | high | |||
| Version: | 5.7.0 | CC: | akarol, cpelland, hkataria, jfrey, jhardy, mpovolny, obarenbo, simaishi | |
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | |
| Target Release: | 5.8.0 | |||
| Hardware: | x86_64 | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | 5.8.0.2 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1423031 (view as bug list) | Environment: | ||
| Last Closed: | 2017-06-12 16:13:02 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | Bug | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | CFME Core | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1423031 | |||
|
Comment 2
Adam Grare
2017-02-14 15:57:27 UTC
Confirmed, I added a log statement to print the snapshot_id passed to raw_revert_to_snapshot and this is the result: [----] I, [2017-02-14T10:56:59.727033 #14187:cf713c] INFO -- : MIQ(ManageIQ::Providers::Vmware::InfraManager::Vm#raw_revert_to_snapshot) ManageIQ::Providers::Vmware::InfraManager::Vm#raw_revert_to_snapshot: snapshot_id: nil [----] E, [2017-02-14T10:56:59.729890 #14187:cf713c] ERROR -- : MIQ(MiqQueue#deliver) Message id: [1000000577076], Error: [Requested VM snapshot not found, unable to RevertTo snapshot] I'll track down where the nil snapshot id is coming from. When reverting to a snapshot the UI uses the session[:snap_selected] property which is set in snap_pressed in ./app/controllers/vm_common.rb When there is only one snapshot the snap_pressed method isn't invoked so by the time the revert_snapshot task is created session[:snap_selected] is nil. Assigning to UI team. Brian, Can you look into it, since you are able to replicate on 5.7.0.17. Let me know if you have questions or need help with the fix. Thanks, ~Harpreet New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/118eae8b360d980c6787c3b1fa3d28f81f762273 commit 118eae8b360d980c6787c3b1fa3d28f81f762273 Author: Brian McLaughlin <bmclaugh> AuthorDate: Thu Feb 16 11:03:26 2017 -0500 Commit: Brian McLaughlin <bmclaugh> CommitDate: Thu Feb 16 13:05:59 2017 -0500 Fix Snapshot revert Ensure that session[:snap_selected] is set as expected https://bugzilla.redhat.com/show_bug.cgi?id=1421951 app/controllers/vm_common.rb | 1 + spec/controllers/vm_common_spec.rb | 50 ++++++++++++++++++++++++-------------- 2 files changed, 33 insertions(+), 18 deletions(-) New commit detected on ManageIQ/manageiq/euwe: https://github.com/ManageIQ/manageiq/commit/b354066d6939387473a60ce3e929cdb0fda73bc3 commit b354066d6939387473a60ce3e929cdb0fda73bc3 Author: Brian McLaughlin <bmclaugh> AuthorDate: Thu Feb 16 11:03:26 2017 -0500 Commit: Brian McLaughlin <bmclaugh> CommitDate: Mon Feb 20 10:00:51 2017 -0500 Fix Snapshot revert Ensure that session[:snap_selected] is set as expected https://bugzilla.redhat.com/show_bug.cgi?id=1421951 app/controllers/vm_common.rb | 1 + spec/controllers/vm_common_spec.rb | 28 ++++++++++++++++++++++++++++ 2 files changed, 29 insertions(+) *** Bug 1419885 has been marked as a duplicate of this bug. *** snapshot revert successful. Verified:5.8.0.8-alpha1.20170328221054_e6ca7a2 |