Bug 1421956

Summary:	Disperse: Fallback to pre-compiled code execution when dynamic code generation fails
Product:	[Community] GlusterFS	Reporter:	Xavi Hernandez <jahernan>
Component:	disperse	Assignee:	Xavi Hernandez <jahernan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	3.10	CC:	anoopcs, bugs, srangana
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.10.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1421955	Environment:
Last Closed:	2017-02-27 15:29:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1421955
Bug Blocks:	1416031

Description Xavi Hernandez 2017-02-14 08:34:50 UTC

+++ This bug was initially created as a clone of Bug #1421955 +++

Description of problem:

If a failure is detected while creating dynamic code, fallback to the pre-compiled version instead of failing.

Version-Release number of selected component (if applicable): mainline


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Niels de Vos 2017-02-14 11:59:01 UTC

The main problem is that ec generates dynamically executable code and permissions (running as non-root or SELinux) can prevent this. Currently the temporary files are created under /usr/libexec to satisfy SELinux, but this is not correct as this path can be read-only (common in containers, but also for non-root gfapi applications).

Without this fix, users may get 'random' failures while using EC volumes.

Comment 2 Worker Ant 2017-02-21 09:47:29 UTC

REVIEW: https://review.gluster.org/16697 (cluster/ec: Fallback to precompiled code) posted (#1) for review on release-3.10 by Pranith Kumar Karampuri (pkarampu)

Comment 3 Worker Ant 2017-02-21 13:43:27 UTC

COMMIT: https://review.gluster.org/16697 committed in release-3.10 by Shyamsundar Ranganathan (srangana) 
------
commit 13637202d6d4055b1542492c988b3e9fe84e5bde
Author: Xavier Hernandez <xhernandez>
Date:   Tue Feb 14 11:12:58 2017 +0100

    cluster/ec: Fallback to precompiled code
    
    When dynamic code generation fails for some reason, instead of causing
    a failure in encode/decode, fallback to the precompiled version.
    
     >Change-Id: I4f8a97d3033aa5885779722b19c6e611caa4ffea
     >BUG: 1421955
     >Signed-off-by: Xavier Hernandez <xhernandez>
     >Reviewed-on: https://review.gluster.org/16614
     >Smoke: Gluster Build System <jenkins.org>
     >NetBSD-regression: NetBSD Build System <jenkins.org>
     >Reviewed-by: Niels de Vos <ndevos>
     >CentOS-regression: Gluster Build System <jenkins.org>
     >Reviewed-by: Pranith Kumar Karampuri <pkarampu>
     >(cherry picked from commit 9f9d1482868e8e1044790c8358893f4421d89692)
    
    Change-Id: I5e6221fce7a77782fd7d961e752a61dd59821a98
    BUG: 1421956
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: https://review.gluster.org/16697
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 4 Shyamsundar 2017-02-27 15:29:03 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-devel/2017-February/052173.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 5 Shyamsundar 2017-03-06 17:46:17 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html
[2] https://www.gluster.org/pipermail/gluster-users/