Bug 1422441

Summary:	ffsb: should not use getrandom
Product:	[Fedora] Fedora	Reporter:	Florian Weimer <fweimer>
Component:	ffsb	Assignee:	Eric Sandeen <esandeen>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	esandeen
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-02-15 17:04:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1422434

Description Florian Weimer 2017-02-15 10:57:36 UTC

ffsb defines a function called “getrandom” which overrides the glibc function of the same name.  However, the ffsb version behaves in a completely different way.  This can lead to problems in the future, particularly if ffsb starts to link to against additional shared objects, or if it uses NSS (the Name Service Switch in glibc).

Comment 1 Eric Sandeen 2017-02-15 15:47:42 UTC

ffsb seems dead upstream, so changes in the future seem unlikely.

Still, I don't mind fixing.  I presume that simply renaming ffsb's function would suffice, yes?

Thanks,
-Eric

Comment 2 Florian Weimer 2017-02-15 15:52:38 UTC

(In reply to Eric Sandeen from comment #1)
> ffsb seems dead upstream, so changes in the future seem unlikely.
> 
> Still, I don't mind fixing.  I presume that simply renaming ffsb's function
> would suffice, yes?

Right, that should do the trick.