Bug 1422441 - ffsb: should not use getrandom
Summary: ffsb: should not use getrandom
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: ffsb
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Eric Sandeen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora26GlibcInterpositionTracker
TreeView+ depends on / blocked
 
Reported: 2017-02-15 10:57 UTC by Florian Weimer
Modified: 2017-02-15 17:04 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-02-15 17:04:34 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Florian Weimer 2017-02-15 10:57:36 UTC 
ffsb defines a function called “getrandom” which overrides the glibc function of the same name.  However, the ffsb version behaves in a completely different way.  This can lead to problems in the future, particularly if ffsb starts to link to against additional shared objects, or if it uses NSS (the Name Service Switch in glibc).
Comment 1 Eric Sandeen 2017-02-15 15:47:42 UTC 
ffsb seems dead upstream, so changes in the future seem unlikely.

Still, I don't mind fixing.  I presume that simply renaming ffsb's function would suffice, yes?

Thanks,
-Eric
Comment 2 Florian Weimer 2017-02-15 15:52:38 UTC 
(In reply to Eric Sandeen from comment #1)
> ffsb seems dead upstream, so changes in the future seem unlikely.
> 
> Still, I don't mind fixing.  I presume that simply renaming ffsb's function
> would suffice, yes?

Right, that should do the trick.
Note You need to log in before you can comment on or make changes to this bug.