Bug 1422532

Summary: gcc7 compiled firefox looks seriously broken
Product: [Fedora] Fedora Reporter: Mamoru TASAKA <mtasaka>
Component: firefoxAssignee: Martin Stransky <stransky>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: atu, awilliam, gecko-bugs-nobody, jakub_o, jcollin, jfrieben, jhorak, kengert, kevin, meissner, oholy, pgrunt, pjasicek, pschindl, renault, robatino, samuel-rhbugs, stransky, viorel.tabara
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: firefox-51.0.1-6.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-23 19:37:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1349184    
Attachments:
Description Flags
screenshot with gcc6 compiled firefox
none
screenshot with gcc7 compiled firefox
none
startup with 51.0.1-5.fc26 showing crash reporter
none
gdb log none

Description Mamoru TASAKA 2017-02-15 13:24:16 UTC
Description of problem:
Looks like with gcc7 compiled firefox (firefox-51.0.1-3.fc26), browsing any web page looks seriously broken.

Just downgrading firefox only to firefox-51.0.1-2.fc26 restores "good" looking at browsing web pages.


Version-Release number of selected component (if applicable):
firefox-51.0.1-3.fc26

How reproducible:
100%

Steps to Reproduce:
1. browse any web pages with firefox-51.0.1-3.fc26
2.
3.

Actual results:
Very bad.

Expected results:
As was with firefox-51.0.1-2.fc26

Additional info:
Some screenshot will be attached.

Comment 1 Mamoru TASAKA 2017-02-15 13:27:05 UTC
Created attachment 1250608 [details]
screenshot with gcc6 compiled firefox

https://start.fedoraproject.org/ with firefox-51.0.1-2.fc26 . Looks normal.

Comment 2 Mamoru TASAKA 2017-02-15 13:30:08 UTC
Created attachment 1250609 [details]
screenshot with gcc7 compiled firefox

https://start.fedoraproject.org/ with firefox-51.0.1-3.fc26 . This one was compiled with gcc7.

Note that
- the right side and bottom side is black
- URL bar is not shown
- And some other things are also broken.

Comment 3 Adam Williamson 2017-02-16 01:54:17 UTC
*** Bug 1422619 has been marked as a duplicate of this bug. ***

Comment 4 Adam Williamson 2017-02-21 16:30:39 UTC
This renders cockpit basically unusable:

https://openqa.fedoraproject.org/tests/57165

Given how bad this is I'm gonna nominate it as an Alpha blocker, as a violation of "It must be possible to run the default web browser and a terminal application from all release-blocking desktop environments. ... The web browser must be able to download files, load extensions (if applicable), and log into FAS." - arguably, you can't reasonably do all those things with a Firefox that looks like this. openQA sure can't. :P

Comment 5 Jan Horak 2017-02-22 09:07:19 UTC
*** Bug 1425729 has been marked as a duplicate of this bug. ***

Comment 6 Martin Stransky 2017-02-22 11:33:40 UTC
*** Bug 1425770 has been marked as a duplicate of this bug. ***

Comment 7 Martin Stransky 2017-02-22 12:29:43 UTC
As a workaround you can use our flatpak packages:

https://firefox-flatpak.mojefedora.cz/

or install binary from mozilla.com.

Comment 8 Kevin Fenzi 2017-02-22 14:35:04 UTC
You can also downgrade to 
https://koji.fedoraproject.org/koji/buildinfo?buildID=836421

which currently has no dep issues or the like.

Comment 9 Kai Engert (:kaie) (inactive account) 2017-02-22 15:47:54 UTC
Does anyone understand what's happening?

Comment 10 Martin Stransky 2017-02-22 16:38:10 UTC
(In reply to Kai Engert (:kaie) from comment #9)
> Does anyone understand what's happening?

Build without optimization works fine so I expect it's some -O3 miscompilation/FF bug whatever. Looking into it.

Comment 11 Martin Stransky 2017-02-23 12:21:24 UTC
New build without -O3 optimization is here:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18011812

Comment 12 Mamoru TASAKA 2017-02-23 13:49:50 UTC
Created attachment 1256931 [details]
startup with 51.0.1-5.fc26 showing crash reporter

(In reply to Martin Stransky from comment #11)
> New build without -O3 optimization is here:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=18011812

Doesn't seem good.. For me this crashes on startup (i.e. this does not launch) and crash reporter appears.

Comment 13 Mamoru TASAKA 2017-02-23 13:52:41 UTC
(In reply to Mamoru TASAKA from comment #12)
> Created attachment 1256931 [details]
> startup with 51.0.1-5.fc26 showing crash reporter

Although this picture's file name is "startup-ff-51.0.1-2.fc26.x86_64.png", this is actually with firefox-51.0.1-5.fc26.x86_64

Comment 14 Mamoru TASAKA 2017-02-23 15:34:57 UTC
Created attachment 1256966 [details]
gdb log

gdb backtrace for firefox-51.0.1-5.fc26.x86_64

Comment 15 Yanko Kaneti 2017-02-23 16:32:47 UTC
*** Bug 1426181 has been marked as a duplicate of this bug. ***

Comment 16 Kai Engert (:kaie) (inactive account) 2017-02-23 16:51:50 UTC
I've also experimented with local builds, because I need to test a code change to firefox, and the -O2 build crashed for me, too.

Instead of the approach that Martin had commited, I added the following statement (which is usually used for firefox debug builds):

   MOZ_OPT_FLAGS=$(echo "$MOZ_OPT_FLAGS" | %{__sed} -e 's/-O2//')

This change disables the -O2 flag, that is obtained from this line:
  MOZ_OPT_FLAGS=$(echo "$RPM_OPT_FLAGS" | %{__sed} -e 's/-Wall//')

The local build I've produced that way works for me, without apparent visual issues.

Comment 17 Martin Stransky 2017-02-23 17:19:42 UTC
(In reply to Mamoru TASAKA from comment #12)
> Created attachment 1256931 [details]
> startup with 51.0.1-5.fc26 showing crash reporter
> 
> (In reply to Martin Stransky from comment #11)
> > New build without -O3 optimization is here:
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=18011812
> 
> Doesn't seem good.. For me this crashes on startup (i.e. this does not
> launch) and crash reporter appears.

That seems to be mozbz#1321579

Comment 18 Martin Stransky 2017-02-23 19:37:22 UTC
New builds are available at https://koji.fedoraproject.org/koji/buildinfo?buildID=861526

Comment 19 Mamoru TASAKA 2017-02-23 20:18:21 UTC
(In reply to Martin Stransky from comment #18)
> New builds are available at
> https://koji.fedoraproject.org/koji/buildinfo?buildID=861526

This works for me, thank you!

Comment 20 Jakub 2017-02-24 12:24:08 UTC
hasnt there been the change in gcc in fedora that allows indefined use of functions or something..? (disables warning about them, that prevents compiling)