Bug 1422629

Summary:	Flower support in tc
Product:	Red Hat Enterprise Linux 7	Reporter:	Phil Sutter <psutter>
Component:	iproute	Assignee:	Jonathan Toppins <jtoppins>
Status:	CLOSED ERRATA	QA Contact:	Li Shuang <shuali>
Severity:	medium	Docs Contact:	Ioanna Gkioka <igkioka>
Priority:	medium
Version:	7.4	CC:	atragler, jaster, jiji, jtoppins, mjahoda, omoris
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	iproute-3.10.0-78.el7	Doc Type:	Enhancement
Doc Text:	The tc utility now supports flower The tc utility has been enhanced to use the kernel flower traffic control classifier. With this update, a user can add, modify, or delete flower classifier rules from an interface.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-01 21:32:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1393375
Bug Blocks:	1353018

Description Phil Sutter 2017-02-15 17:47:15 UTC

In order to make use of and properly test flower scheduler backport in RHEL7 kernel, support for it in 'tc' utility should be backported as well.

Comment 1 Phil Sutter 2017-02-15 17:51:53 UTC

Ah, my bad: Flower is not a scheduler, but a classifier.

Comment 3 Ondrej Moriš 2017-03-14 14:41:45 UTC

Jonathan, would you help us identifying the most important test cases? Is there anything specific we should focus on during the testing?

Comment 5 Jonathan Toppins 2017-03-22 21:45:34 UTC

(In reply to Ondrej Moriš from comment #3)
> Jonathan, would you help us identifying the most important test cases? Is
> there anything specific we should focus on during the testing?

Yes I would be happy to review any test plans so that I can make useful suggestions based on what you are already covering.

I am currently reviewing the netsched test plan[1].

In general I would focus on basic functionality, for example given 3 tcp streams can flower filter one of those streams and drop/mark it.

I would then take this basic test and then attempt to run the same test while trying to have hardware offload the filtering, which some devices can do.

These are functional tests however and maybe I am missing the level and type of testing your team needs to do.

[1] https://wiki.test.redhat.com/Kernel/Testplans/RHEL74Netsched

Comment 6 Li Shuang 2017-05-17 02:09:16 UTC

Hi Jonathan,

I have also written some tests which focus on the basic functionality. In these cases I add some tc rules with most of tc-flower options, send traffic, and then check if the traffic could be matched and dropped successfully.

Now it shows that the results of my tests are all passed, so do you think I can set this bz to Verified? 

Thanks, Shuang

Comment 11 errata-xmlrpc 2017-08-01 21:32:13 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2171