RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1422629 - Flower support in tc
Summary: Flower support in tc
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: iproute
Version: 7.4
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Jonathan Toppins
QA Contact: Li Shuang
Ioanna Gkioka
URL:
Whiteboard:
Depends On: 1393375
Blocks: 1353018
TreeView+ depends on / blocked
 
Reported: 2017-02-15 17:47 UTC by Phil Sutter
Modified: 2018-02-23 14:56 UTC (History)
6 users (show)

Fixed In Version: iproute-3.10.0-78.el7
Doc Type: Enhancement
Doc Text:
The *tc* utility now supports *flower* The *tc* utility has been enhanced to use the kernel *flower* traffic control classifier. With this update, a user can add, modify, or delete *flower* classifier rules from an interface.
Clone Of:
Environment:
Last Closed: 2017-08-01 21:32:13 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:2171 0 normal SHIPPED_LIVE iproute bug fix and enhancement update 2017-08-01 18:40:13 UTC

Description Phil Sutter 2017-02-15 17:47:15 UTC 
In order to make use of and properly test flower scheduler backport in RHEL7 kernel, support for it in 'tc' utility should be backported as well.
Comment 1 Phil Sutter 2017-02-15 17:51:53 UTC 
Ah, my bad: Flower is not a scheduler, but a classifier.
Comment 3 Ondrej Moriš 2017-03-14 14:41:45 UTC 
Jonathan, would you help us identifying the most important test cases? Is there anything specific we should focus on during the testing?
Comment 5 Jonathan Toppins 2017-03-22 21:45:34 UTC 
(In reply to Ondrej Moriš from comment #3)
> Jonathan, would you help us identifying the most important test cases? Is
> there anything specific we should focus on during the testing?

Yes I would be happy to review any test plans so that I can make useful suggestions based on what you are already covering.

I am currently reviewing the netsched test plan[1].

In general I would focus on basic functionality, for example given 3 tcp streams can flower filter one of those streams and drop/mark it.

I would then take this basic test and then attempt to run the same test while trying to have hardware offload the filtering, which some devices can do.

These are functional tests however and maybe I am missing the level and type of testing your team needs to do.

[1] https://wiki.test.redhat.com/Kernel/Testplans/RHEL74Netsched
Comment 6 Li Shuang 2017-05-17 02:09:16 UTC 
Hi Jonathan,

I have also written some tests which focus on the basic functionality. In these cases I add some tc rules with most of tc-flower options, send traffic, and then check if the traffic could be matched and dropped successfully.

Now it shows that the results of my tests are all passed, so do you think I can set this bz to Verified? 

Thanks, Shuang
Comment 11 errata-xmlrpc 2017-08-01 21:32:13 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2171
Note You need to log in before you can comment on or make changes to this bug.