Bug 1423429

Summary:	unnecessary logging in rda_opendir
Product:	[Community] GlusterFS	Reporter:	Poornima G <pgurusid>
Component:	read-ahead	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.10	CC:	bugs, srangana
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.10.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1423369	Environment:
Last Closed:	2017-02-27 15:30:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1423369
Bug Blocks:	1416031

Description Poornima G 2017-02-17 10:07:49 UTC

+++ This bug was initially created as a clone of Bug #1423369 +++

Description of problem:
The below log messages are seen on client logs:

[2017-02-16 18:57:10.358205] E [MSGID: 129006]
[readdir-ahead.c:576:rda_opendir] 0-testvolssd-readdir-ahead: Dict get
of key:readdir-filter-directories failed with :-2
The message "E [MSGID: 129006] [readdir-ahead.c:576:rda_opendir]
0-testvolssd-readdir-ahead: Dict get of key:readdir-filter-directories
failed with :-2" repeated 8 times between [2017-02-16 18:57:10.358205]
and [2017-02-16 18:59:02.529601]

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2017-02-17 01:51:33 EST ---

REVIEW: https://review.gluster.org/16654 (readdir-ahead: Remove unnecessary logging) posted (#2) for review on master by Poornima G (pgurusid)

Comment 1 Worker Ant 2017-02-17 10:08:22 UTC

REVIEW: https://review.gluster.org/16659 (readdir-ahead: Remove unnecessary logging) posted (#1) for review on release-3.10 by Poornima G (pgurusid)

Comment 2 Worker Ant 2017-02-17 15:43:25 UTC

REVIEW: https://review.gluster.org/16659 (readdir-ahead: Remove unnecessary logging) posted (#2) for review on release-3.10 by Poornima G (pgurusid)

Comment 3 Worker Ant 2017-02-17 16:56:04 UTC

COMMIT: https://review.gluster.org/16659 committed in release-3.10 by Shyamsundar Ranganathan (srangana) 
------
commit 8039fcf2571ad7fd9841c8e5605cad9b55d8645c
Author: Poornima G <pgurusid>
Date:   Fri Feb 17 12:17:18 2017 +0530

    readdir-ahead: Remove unnecessary logging
    
    dict_get_int can return < 0 when key is not found is a valid case.
    Hence no need to log.
    
    > Reviewed-on: https://review.gluster.org/16654
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: Jeff Darcy <jdarcy>
    
    Change-Id: If0795b0f178adbb94b10efc563506993f7411962
    BUG: 1423429
    Signed-off-by: Poornima G <pgurusid>
    Reviewed-on: https://review.gluster.org/16659
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 4 Shyamsundar 2017-02-27 15:30:01 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-devel/2017-February/052173.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 5 Shyamsundar 2017-03-06 17:46:38 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html
[2] https://www.gluster.org/pipermail/gluster-users/