Bug 142346

Should be fixed in mkinitrd-4.1.20

This still seems to be too fragile (see "unable to find suitable
template"):

[root@imp mike]# rpm -ivh /tmp/kernel-2.6.9-1.1047_FC4.ppc.rpm
WARNING: Multiple same specifications for /var/run/dbus(/.*)?.
Preparing...               
########################################### [100%]
   1:kernel                
########################################### [100%]
WARNING: /lib/modules/2.6.9-1.1047_FC4/kernel/drivers/video/vga16fb.ko
needs unknown symbol vgacon_remap_base
grubby fatal error: unable to find a suitable template
[root@imp mike]# rpm -q mkinitrd
mkinitrd-4.1.20-1

What is grubby looking for in /etc/yaboot.conf?  Here is mine:

boot=/dev/sda2
ofboot=/pci@f2000000/usb@1b,1/disk@1:2
init-message="Welcome to imp!\nHit <TAB> for boot options.\n\n"
partition=3
timeout=30
install=/usr/lib/yaboot/yaboot
default=2.6.9-1.1021_FC
magicboot=/usr/lib/yaboot/ofboot
macosx=/dev/hda7
enablecdboot
delay=10
defaultos=linux
default=2.6.9-1.1021_FC
image=/vmlinuz-2.6.9-1.1021_FC4
        label=2.6.9-1.1021_FC
        append="enforcing=1"
        root=/dev/hda5
        initrd=/initrd-2.6.9-1.1021_FC4.img
        read-only
image=/vmlinuz-2.6.9-1.1020_FC4
        label=2.6.9-1.1020_FC
        append="enforcing=0"
        root=/dev/hda5
        initrd=/initrd-2.6.9-1.1020_FC4.img
        read-only

I think you can scratch comment #2.  I am doing some unrelated work
with mkinitrd that goofed up my results.  I still see the same things
as documented in the initial report.

*** Bug 164980 has been marked as a duplicate of this bug. ***

Created attachment 117403 [details]
Patch

The problem is that grubby thinks that a whole bunch of generic config options
which live at the top of the file are in fact selections in the boot menu, like
'other' in Grub. This includes 'magicboot=', 'macosx=', etc. 

This patch should fix it.

Dave, can you add test case fixes that are appropriate for both the correct way
and the regressions?

Currently the patch you have doesn't match the testcases, and I don't know what
yaboot.conf _should_ look like in these cases.

Hm, when the generic (first-stage) options like 'macosx=' are mixed in with the
kernel choices for the second stage, as they are in test/yaboot.1, grubby is
assuming that the 'macosx=' line is part of the image definition and is
reproducing it when it adds a new kernel based on the one which is above the
'macosx=' line.

It also _removes_ the macosx= option if it happens to come after a kernel which
is being removed.

Unfortunately this bug is going to have created config files which look like
that, so fixing it this way isn't really going to work. 

We possibly need to add a new line type for generic config options which
_aren't_ part of an image definition.

Created attachment 117440 [details]
Patch to fix test cases

This makes the expected output of the test cases saner, with generic (or
first-stage) options collected at the top of the file instead of in the middle
of the kernel images for the second stage yaboot.

Created attachment 117441 [details]
Patch to make grubby pass the newly-modified tests.

This makes grubby move generic config options up to the top of the file, before
the kernel images start.

Created attachment 117442 [details]
Patch to make grubby pass the newly-modified tests.

This makes grubby move generic config options up to the top of the file, before
the kernel images start.

I have not had this problem with Raw Hide grubby for quite some time.  Marking
as resolved.