Bug 1424233
| Summary: | Review Request: GNOME Internet Radio Locator - Locate Internet Radio Stations | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ole Aamot <oka> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | c72578, leigh123linux, ole, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-11-29 13:59:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 177841 | ||
|
Description
Ole Aamot
2017-02-17 16:24:14 UTC
I've updated the package to 10.0.0 which is based on gstreamer for playback of the included 86 Internet Radio stations. Spec URL: https://people.gnome.org/~ole/girl/girl.spec SRPM URL: https://people.gnome.org/~ole/girl/girl-10.0.0-1.fc25.src.rpm Description: Locate Internet Radio Stations Fedora Account System Username: oka See https://wiki.gnome.org/Apps/Girl and https://people.gnome.org/~ole/girl/ I would like to see GNOME Internet Radio Locator included in Fedora Rawhide after December 31, 2017 when the Frauenhofer MP3 patents expire. Best, Ole Hello Ole, here are some comments: - Please remove "Applications/Internet" from spec file, which is deprecated https://fedoraproject.org/wiki/RPMGroups - Source: could be changed from http://people.gnome.org/~ole/%{name}/%{name}-%{version}.tar.xz to https://download.gnome.org/sources/%(name)/10.0/%{name}-%{version}.tar.xz Because the girl git repo is also at the gnome site: https://git.gnome.org/browse/girl/ - Concerning the changelog entries: The dist should not be added after the version in the changelog and the e-mail address is usually included according to Fedora guidelines. https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs e.g.: * Thu May 04 2017 Ole Aamot - 10.0.0-1.fc25 -> * Thu May 04 2017 Ole Aamot <oka> - 10.0.0-1 Best regards Wolfgang Spec URL: https://people.gnome.org/~ole/girl/girl.spec SRPM URL: https://people.gnome.org/~ole/girl/girl-10.0.0-2.fc26.src.rpm Description: Locate Internet Radio Stations Fedora Account System Username: oka A couple of issues 1. This Requires: gstreamer1-plugins-ugly >= 1.8.3 should be Requires: gstreamer1-plugins-ugly-free >= 1.8.3 as your not allowed to require a rpmfusion package 2. Remove the obsolete scriptlets for mime /usr/bin/update-desktop-database &> /dev/null || : https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#desktop-database Spec URL: https://people.gnome.org/~ole/girl/girl.spec SRPM URL: https://people.gnome.org/~ole/girl/girl-10.0.0-3.fc26.src.rpm Description: Locate Internet Radio Stations Fedora Account System Username: oka Fedora f26-candidate koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21191960 You missed one of the mime scriptlets /usr/bin/update-desktop-database &> /dev/null || : Spec URL: https://people.gnome.org/~ole/girl/girl.spec SRPM URL: https://people.gnome.org/~ole/girl/girl-10.0.0-4.fc26.src.rpm Description: Locate Internet Radio Stations Fedora Account System Username: oka Fedora f26-candidate koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21194234 Obsolete package. See bug #1517451 |