Spec URL: https://people.gnome.org/~ole/gnome-internet-radio-locator/gnome-internet-radio-locator.spec SRPM URL: https://people.gnome.org/~ole/gnome-internet-radio-locator/gnome-internet-radio-locator-1.0.0-1.fc26.src.rpm Description: Locate Internet Radio Stations Fedora Account System Username: oka
*** Bug 1161834 has been marked as a duplicate of this bug. ***
How does this new program related to "girl", which is shipped by rpmfusion? https://bugzilla.rpmfusion.org/show_bug.cgi?id=3485 -> https://bugzilla.rpmfusion.org/show_bug.cgi?id=3693
The program gnome-internet-radio-locator replaces it and is based on GTK+ 3.0, GNOME Maps, libchamplain and gst-player.
new version 1.0.2 is available.
Spec URL: https://people.gnome.org/~ole/gnome-internet-radio-locator/gnome-internet-radio-locator.spec SRPM URL: https://people.gnome.org/~ole/gnome-internet-radio-locator/gnome-internet-radio-locator-1.1.0-1.fc27.src.rpm Description: Locate Internet Radio Stations Fedora Account System Username: oka
I have built RPM packages for testing: Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.1-1.fc27.src.rpm
Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.1-1.fc28.src.rpm Description: Locate Internet Radio Stations Fedora Account System Username: oka I have built RPM packages for fc27 and fc28. https://people.gnome.org/~ole/testing/RPMS/x86_64/gnome-internet-radio-locator-1.1.1-1.fc27.x86_64.rpm https://people.gnome.org/~ole/testing/RPMS/x86_64/gnome-internet-radio-locator-1.1.1-1.fc28.x86_64.rpm https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.1-1.fc27.src.rpm https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.1-1.fc28.src.rpm
1. where is the correct link to the SOURCE file: gnome-internet-radio-locator-1.1.1.tar.xz 2. the Group Tag isn't need any longer, please remove it from the spec file. Group: Applications/Internet 3. Can you use the %{url} macro in Source0 Source: %{url}/%{name}-%{version}.tar.xz
Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.2-1.fc28.src.rpm Description: Locate Internet Radio Stations Fedora Account System Username: oka I have built gnome-internet-radio-locator 1.1.2 for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=26591016 I have built a RPM package for fc28 x86_64 from the SRPM: https://people.gnome.org/~ole/testing/RPMS/x86_64/gnome-internet-radio-locator-1.1.2-1.fc28.x86_64.rpm
please correct your spec file again ! rpmlint reports: rpmlint -i -v gnome-internet-radio-locator.x86_64: W: incoherent-version-in-changelog 1.1.2-2 ['1.1.2-1.fc29', '1.1.2-1'] a better description for the %changelog section would: %changelog * Fri Apr 27 2018 Ole Aamot <ole> - 1.1.2-1 - Update to 1.1.2
Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.2-1.fc28.src.rpm
please remove executing gtk-update-icon-cache in %post/%postu/%postrans to update hicolor theme cache All those scriptles are no longer needed because in hicolor-icon-theme package has file triggers updating theme cache on any change in single dnf/rpm transaction. https://pagure.io/packaging-committee/issue/736 remove this part from the spec file: /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : %postun if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi %posttrans /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.3-1.fc28.src.rpm Build for rawhide on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=26593257
1. please remove %post from the spec file 2. please change the description in the %changelog section to %changelog * Fri Apr 27 2018 Ole Aamot <ole> - 1.1.3-1 - Update to 1.1.3
1. I have removed %post and built and published 1.1.3-3 for Fedora Core 28. Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.3-3.fc28.src.rpm 2. I prefer to keep the style for %changelog comments since version 0.1.0.
(In reply to ole from comment #15) > 1. I have removed %post and built and published 1.1.3-3 for Fedora Core 28. > > Spec URL: > https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec > SRPM URL: > https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1. > 3-3.fc28.src.rpm good > 2. I prefer to keep the style for %changelog comments since version 0.1.0. I do not agree with that. Your Changelog entries should provide a brief summary of the changes done to the package. https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs * Mon May 07 2018 Ole Aamot <ole> - 1.1.3-3 - gnome-internet-radio-locator 1.1.3 build on Fedora Linux that are completely useless information, like the name of the program and for which version the program was built. This is a short and meaningful description: * Mon May 07 2018 Ole Aamot <ole> - 1.1.3-3 - Update to 1.1.3
There is no such thing as useless information. There is no useless information in the ChangeLog entry. I have written the software, I release the software and I maintain the released version for the Fedora release. I have built 1.4.0-0 on Fedora Core 28 and my ChangeLog entry describes this. Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.4.0-1.fc28.src.rpm
please remove %post from the spec file, it's empty and not needed.
- Remove %post - Run %make_build after %configure - Appdata file should now be installed in /usr/share/metainfo . Patch your install scrip appropriately. appstream-util validate-relax --nonet %{buildroot}/%{_metainfodir}/%{name}.appdata.xml %{_metainfodir}/%{name}.appdata.xml
Can you remove the DEBIAN file as I doubt the content is useful for Fedora. %doc AUTHORS DEBIAN NEWS README TODO ChangeLog
no feedback ...
I have built 1.6.0-0 on Fedora Core 28. Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.6.0-1.fc28.src.rpm Sources: https://download.gnome.org/sources/gnome-internet-radio-locator/1.6/gnome-internet-radio-locator-1.6.0.tar.xz
Why does playback of stations on the map markers for London, United Kingdom Oslo, Norway Stockholm, Sweden Ayr, Scotland not work on Hewlett Packard with European Regulatory Address running Fedora Core 28?
- Add gcc as a BR: BuildRequires: gcc - This is the same file: %{_bindir}/%{name} %{_bindir}/gnome-internet-radio-locator - The Version-Release in your %changelog entry should be 1.6.0-1 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: BUILDSTDERR: warning: File listed twice: /usr/bin/gnome-internet- radio-locator See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GNU General Public License (v3)", "FSF All Permissive License", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "GNU Lesser General Public License (v2 or later)", "GNU Lesser General Public License (v2.1 or later)", "Expat License", "FSF Unlimited License (with Retention) GNU General Public License", "FSF Unlimited License (with Retention)". 88 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/gnome-internet-radio-locator/review-gnome- internet-radio-locator/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/icons/hicolor/1024x1024/apps, /usr/share/icons/hicolor/1024x1024 [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 102400 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gnome- internet-radio-locator-debuginfo , gnome-internet-radio-locator- debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gnome-internet-radio-locator-1.6.0-1.fc30.x86_64.rpm gnome-internet-radio-locator-debuginfo-1.6.0-1.fc30.x86_64.rpm gnome-internet-radio-locator-debugsource-1.6.0-1.fc30.x86_64.rpm gnome-internet-radio-locator-1.6.0-1.fc30.src.rpm gnome-internet-radio-locator.x86_64: W: spelling-error %description -l en_US gstreamer -> streamer, g streamer, steamer gnome-internet-radio-locator.x86_64: W: incoherent-version-in-changelog 1.6.0-0 ['1.6.0-1.fc30', '1.6.0-1'] gnome-internet-radio-locator.src: W: spelling-error %description -l en_US gstreamer -> streamer, g streamer, steamer 4 packages and 0 specfiles checked; 0 errors, 3 warnings.
Spec URL: https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec SRPM URL: https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-2.0.0-1.fc29.src.rpm Description: Locate Internet Radio Stations Fedora Account System Username: oka I have built RPM packages for fc29 x86_64: https://people.gnome.org/~ole/testing/RPMS/x86_64/gnome-internet-radio-locator-2.0.0-1.fc29.x86_64.rpm https://people.gnome.org/~ole/testing/RPMS/x86_64/gnome-internet-radio-locator-2.0.0-1.fc29.x86_64.rpm https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-2.0.0-1.fc29.src.rpm https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-2.0.0-1.fc29.src.rpm I have not yet released 2.0.0 upstream, but I plan to release it as soon as I get feedback on RPMS.
LGTM, package approved. You still need to find a sponsor however.
Spec URL: http://www.gnomeradio.org/~ole/fedora/SPECS/gnome-internet-radio-locator.spec SRPM URL: http://www.gnomeradio.org/~ole/fedora/SRPMS/gnome-internet-radio-locator-3.6.0-1.fc32.src.rpm Description: Locate and stream Internet Radio stations from graphical, zoomable map Fedora Account System Username: oka I have built RPM packages for fc32 x86_64: http://www.gnomeradio.org/~ole/fedora/RPMS/x86_64/gnome-internet-radio-locator-3.6.0-1.fc32.x86_64.rpm http://www.gnomeradio.org/~ole/fedora/SRPMS/gnome-internet-radio-locator-3.6.0-1.fc32.src.rpm I have not yet released 4.0.0 upstream, but I plan to release it as soon as I get feedback on the RPMS. gnome-radio 0.1.0 is in fc33, while gnome-internet-radio-locator 3.6.0 is not part of rawhide and fc33. See https://linuxreviews.org/GNOME_Internet_Radio_Locator_3.0.5_Is_Released_With_More_Radio_Stations and http://www.gnomeradio.org/~ole/GUADEC2020.pdf Best, Ole
Your package is already approved you list need to find someone to sponsor you into the packager group. See https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
Spec URL: http://people.gnome.org/~ole/fedora/SPECS/gnome-internet-radio-locator.spec SRPM URL: http://people.gnome.org/~ole/fedora/SRPMS/gnome-internet-radio-locator-12.0.1-1.fc34.src.rpm Description: Locate and stream Internet Radio stations from graphical, zoomable map Fedora Account System Username: oka I have built RPM packages for fc34 x86_64: http://people.gnome.org/~ole/fedora/RPMS/x86_64/gnome-internet-radio-locator-12.0.1-1.fc34.x86_64.rpm http://people.gnome.org/~ole/fedora/SRPMS/gnome-internet-radio-locator-12.0.1-1.fc34.src.rpm I have not yet released 12.1.0 upstream, but I plan to release it as soon as I get feedback on the RPMS. gnome-radio 0.1.0 is in fc35, while gnome-internet-radio-locator 12.0.1 is not part of rawhide and fc35. See http://www.gnomeradio.org/~ole/GUADEC2021.pdf for the latest information about GNOME Radio. Best, Ole
Package was never imported. The ticket status is being reset, since creating the repository will require a fresh approval. Let us know if you're still interested in this package.
Spec URL: https://www.gnomeradio.org/~ole/fedora/SPECS/gnome-radio.spec SRPM URL: https://www.gnomeradio.org/~ole/fedora/SRPMS/gnome-radio-46.0-1.fc36.src.rpm Description: Locate Internet Radio Stations Fedora Account System Username: oka
I have built RPM packages for fc36 x86_64: http://www.gnomeradio.org/~ole/fedora/RPMS/x86_64/gnome-radio-46.0-1.fc36.x86_64.rpm http://people.gnome.org/~ole/fedora/SRPMS/gnome-radio-46.0-1.fc36.src.rpm I have not yet released 46.0 upstream, but I plan to release it as soon as I get feedback on the RPMS. gnome-radio 46.0 is in fc36, while gnome-internet-radio-locator 12.7.0 is not part of rawhide and fc37. gnome-radio 46.0 ships the 3 executables org.gnome.Radio, gnome-radio and gnome-internet-radio-locator. See http://www.gnomeradio.org/~ole/GUADEC2022.pdf for the latest information about GNOME Radio. Best, Ole
@ole - How Can I help?
I have built RPM packages for fc37 x86_64: http://www.gnomeradio.org/~ole/fedora/RPMS/x86_64/gnome-radio-64.0-1.fc37.x86_64.rpm http://www.gnomeradio.org/~ole/fedora/SRPMS/gnome-radio-64.0-1.fc37.src.rpm I have not permissions to release new releases upstream, but I hope to release it as soon as I get feedback on the RPMS. gnome-radio 64.0 is not yet in fc37, while gnome-internet-radio-locator 12.7.0 is not part of rawhide and fc37. gnome-radio 64.0 ships the 3 executables /usr/bin/org.gnome.Radio, /usr/bin/gnome-radio and /usr/bin/gnome-internet-radio-locator. See http://wiki.gnome.org/Apps/Radio and http://www.gnomeradio.org/~ole/GUADEC2022.pdf for the latest information on GNOME Radio. Try sudo dnf install http://www.gnomeradio.org/~ole/fedora/RPMS/x86_64/gnome-radio-64.0-1.fc37.x86_64.rpm to test it. I think it needs a sponsor. Best, Ole
Hi, I tested it out on the new branche release, it work okay, but it throws errors like this while initializing and then me tring to search for a location: [bogomil@fedora ~]$ ../src/intel/isl/isl.c:2235: FINISHME: ../src/intel/isl/isl.c:isl_surf_supports_ccs: CCS for 3D textures is disabled, but a workaround is available. (gnome-radio:8193): Clutter-CRITICAL **: 05:24:30.454: clutter_actor_add_child: assertion 'child->priv->parent == NULL' failed Failed to open /home/bogomil/.gnome-radio/gnome-radio.xml ** (gnome-radio:8193): CRITICAL **: 05:24:45.750: geocode_place_get_town: assertion 'GEOCODE_IS_PLACE (place)' failed
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
I have built RPM packages for fc39 x86_64: http://www.gtkradio.org/~ole/fedora/RPMS/x86_64/gtk-radio-264.1-1.fc39.x86_64.rpm http://www.gtkradio.org/~ole/fedora/SRPMS/gtk-radio-264.1-1.fc39.src.rpm I have not permissions to release new releases upstream, but I hope to release it as soon as I get feedback on the RPMS. gtk-radio 264.1 is not yet in fc39, while gnome-internet-radio-locator 12.7.0 is not yet part of rawhide and fc39. gtk-radio 264.1 ships the 4 executables /usr/bin/org.gnome.Radio, /usr/bin/gnome-radio, /usr/bin/gnome-internet-radio-locator and /usr/bin/gtk-radio See http://wiki.gnome.org/Apps/Radio and http://www.gtkradio.org/~ole/GUADEC2023.pdf for the latest information on GTK Radio. Try sudo dnf install http://www.gtkradio.org/~ole/fedora/RPMS/x86_64/gtk-radio-264.1-1.fc39.x86_64.rpm to test it. I think it needs a sponsor. Best, Ole
girl is FTBFS on F40 https://koji.rpmfusion.org/koji/packageinfo?packageID=452 we should replace it with gtk-radio Please update Spec and SRPM URL Thank you
(In reply to Sergio Basto from comment #38) > girl is FTBFS on F40 > https://koji.rpmfusion.org/koji/packageinfo?packageID=452 Antonio fixed it: https://koji.rpmfusion.org/koji/buildinfo?buildID=28273 . > we should replace it with gtk-radio Why? If anything, gtk-radio should unbundle girl and use the system one.
(In reply to Dominik 'Rathann' Mierzejewski from comment #39) > (In reply to Sergio Basto from comment #38) > > we should replace it with gtk-radio > > Why? If anything, gtk-radio should unbundle girl and use the system one. To elaborate, girl appears to be maintained upstream: https://gitlab.gnome.org/GNOME/gnome-internet-radio-locator Last commit was 4 months ago.
(In reply to Dominik 'Rathann' Mierzejewski from comment #40) [...] > To elaborate, girl appears to be maintained upstream: > https://gitlab.gnome.org/GNOME/gnome-internet-radio-locator > > Last commit was 4 months ago. Ok, upon further reading it does seem like upstream intends to replace it with gtk-radio. I guess we should proceed here, then. Some review comments below: Provides: gtk-internet-radio-locator >= 128.0 Drop the greater-than, this should be equal only. You are also mixing tabs and spaces, please replace tabs with spaces in: Obsoletes:<TAB>gtk-internet-radio-locator <= 128.0 Provides:<TAB>gtk-internet-radio-locator = 128.0 %post section is empty, drop it. License: tag is not SPDX-compliant, please fix. %{_mandir}/man1/gnome-radio.1.gz %{_mandir}/man1/gtk-internet-radio-locator.1.gz These should be: %{_mandir}/man1/gnome-radio.1.* %{_mandir}/man1/gtk-internet-radio-locator.1.* and moved next to: %{_mandir}/man1/%{name}.1* building on rawhide-x86_64 fails with: ... configure: error: in `/builddir/build/BUILD/gtk-radio-264.1': configure: error: C compiler cannot create executables See `config.log' for more details config.log duly informs that you forgot to add explicit BuildRequires: gcc: ... configure:4251: gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTI> ./configure: line 4253: gcc: command not found After fixing that, I get: Package 'geoclue-2.0', required by 'virtual:world', not found Package 'libgeoclue-2.0', required by 'virtual:world', not found After fixing that (BuildRequires: pkgconfig(geoclue-2.0)), I get a warning: configure: WARNING: You will not be able to create source packages with 'make dist' because gtk-doc >= 1.16 is not found. and then a compilation error: gnome-radio-location.c: In function ‘location_main’: gnome-radio-location.c:193:27: error: passing argument 3 of ‘gclue_simple_new’ makes pointer from integer without a cast [-Wint-conversion] 193 | time_threshold, | ^~~~~~~~~~~~~~ | | | gint {aka int} and tons of warnings about deprecated GTimeVal usage, e.g.: gnome-radio-location.c:89:9: warning: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead [-Wdeprecated-declarations] This looks suspicious as well: In file included from /usr/include/libgeoclue-2.0/geoclue.h:35, from gnome-radio-location.c:33: /usr/include/libgeoclue-2.0/gclue-simple.h:65:64: note: expected ‘GCancellable *’ {aka ‘struct _GCancellable *’} but argument is of type ‘gint’ {aka ‘int’} 65 | GCancellable *cancellable, | ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ I'd be happy to sponsor you once this package is ready for Fedora Rawhide. Since Robert-André is no longer assigned here, I'll pick up the review.
Once the build errors are fixed (I'll attach a simple patch in a moment), the package builds. The duplicate file noticed by Robert-André earlier still applies: Duplicate build-ids /builddir/build/BUILDROOT/gtk-radio-264.1-1.fc41.x86_64/usr/bin/gnome-radio and /builddir/build/BUILDROOT/gtk-radio-264.1-1.fc41.x86_64/usr/bin/gnome-internet-radio-locator
Created attachment 2026156 [details] patch to fix assignment from incompatible type compilation errors
gtk-radio 384.0 builds, run and ships as a 3rd Party RPM package by Aamot Engineering on Fedora 40. To install gtk-radio 384.0 on Fedora Core 40 x86_64, run sudo dnf install http://www.gtkradio.org/~ole/fedora/RPMS/x86_64/gtk-radio-384.0-1.fc40.x86_64.rpm SPEC: https://www.gtkradio.org/~ole/fedora/SPECS/gtk-radio.spec SOURCES: https://www.gtkradio.org/~ole/fedora/SOURCES/gtk-radio-384.0.tar.xz SRPMS: https://www.gtkradio.org/~ole/fedora/SRPMS/gtk-radio-384.0-1.fc40.src.rpm I don't care about GNOME Foundation, Red Hat or rawhide, I care about GNOME 46 distributions that are stable with a GNOME 46 ABI that will not break for another year, so we can listen to radio and music in real time.
(In reply to Ole Aamot from comment #44) [...] > I don't care about GNOME Foundation, Red Hat or rawhide, Do you want to maintain this package in Fedora or not? If you do, then please address the comments I posted in comment #41 and comment #42 and post links to fixed SPEC file and SRPM. If you don't, then we might as well close this ticket as it's pointless.