Bug 1424825 (xviewer)

*** Bug 1354210 has been marked as a duplicate of this bug. ***

You can remove  these as gnome-common requires them

BuildRequires:	autoconf
BuildRequires:	automake
BuildRequires:	gettext

The package requires gschema scriptlets

%{_datadir}/glib-2.0/schemas/org.x.editor.*gschema.xml


You also have a directory ownership issue on

%{_datadir}/help

change it to 


%{_datadir}/help/*/%{name}/


Do we really need the debian bits?

%license AUTHORS COPYING debian/copyright
%doc ChangeLog README debian/changelog

(In reply to leigh scott from comment #2)

> You also have a directory ownership issue on
> 
> %{_datadir}/help
> 
> change it to 
> 
> 
> %{_datadir}/help/*/%{name}/
> 
> 
> Do we really need the debian bits?
> 
> %license AUTHORS COPYING debian/copyright
> %doc ChangeLog README debian/changelog

I posted this to the wrong review
The above comments also apply to this package, please fix them.

And

The package requires gschema scriptlets

%{_datadir}/glib-2.0/schemas/*.xml

(In reply to leigh scott from comment #2)
> You can remove  these as gnome-common requires them
> 
> BuildRequires:	autoconf
> BuildRequires:	automake
> BuildRequires:	gettext

Well, explicit BRs don't hurt.  ;)


> The package requires gschema scriptlets
> 
> %{_datadir}/glib-2.0/schemas/org.x.editor.*gschema.xml

Those are obsolete since F24+.  See:  https://fedoraproject.org/wiki/Packaging:Scriptlets#GSettings_Schema


> You also have a directory ownership issue on
> 
> %{_datadir}/help
> 
> change it to 
> 
> %{_datadir}/help/*/%{name}/

Will fix that in short.


> Do we really need the debian bits?
> 
> %license AUTHORS COPYING debian/copyright
> %doc ChangeLog README debian/changelog

I package them, since the debian-changelog is usually more up2date…

***

Updated package:

Urls:

Spec URL:  https://pagure.io/besser82/package-review/raw/master/f/xviewer.spec
  SRPM URL:  https://pagure.io/besser82/package-review/raw/master/f/xviewer-1.2.2-0.2.fc26.src.rpm

Approved

Please fix the ownership issue on

%doc %{_datadir}/gtk-doc

change it to 

%doc %{_datadir}/gtk-doc/html/%{name}

when you import it


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.page is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- glib-compile-schemas is run in %postun and %posttrans if package has
  *.gschema.xml files.
  Note: gschema file(s) in xviewer
  See:
  http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema


===== MUST items =====

C/C++:
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL", "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or
     generated", "GPL (v2 or later) LGPL (v2 or later)", "MIT/X11 (BSD
     like)", "*No copyright* CC by-sa (v3.0)", "CC by-sa (v3.0)", "*No
     copyright* GPL (v2 or later)". 310 files have unknown license.
     Detailed output of licensecheck in
     /home/leigh/Desktop/1424825-xviewer/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/help/ar, /usr/share/help/th,
     /usr/share/help/pa
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/help/lv,
     /usr/share/help/fi, /usr/share/help/uk, /usr/share/help/de,
     /usr/share/help/da, /usr/share/help/sv, /usr/share/help/hu,
     /usr/share/help/fr, /usr/share/help/pl, /usr/share/help/C,
     /usr/share/help/ja, /usr/share/help/es, /usr/share/GConf/gsettings,
     /usr/share/help/eu, /usr/share/help/ar, /usr/share/help/ca,
     /usr/share/help/ro, /usr/share/GConf, /usr/share/help/el,
     /usr/share/help/en_GB, /usr/share/help/gl, /usr/share/help/pa,
     /usr/share/help/pt_BR, /usr/share/help/oc, /usr/share/help/it,
     /usr/share/help/sl, /usr/share/help/zh_TW, /usr/share/help/te,
     /usr/share/help/cs, /usr/share/help/ko, /usr/share/help/ru,
     /usr/share/help/th, /usr/share/help/zh_CN
[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/gtk-doc(gnome-
     desktop3-devel, libgnome-keyring-devel, libsecret-devel, gcr-devel,
     polkit-docs, p11-kit-devel, libpeas-devel, harfbuzz-devel,
     libcanberra-devel, json-glib-devel, clutter-gst3-devel, libgdata-
     devel, gnome-bluetooth-libs-devel, gtk-doc), /usr/share/gtk-doc/html
     (gnome-desktop3-devel, libgnome-keyring-devel, libsecret-devel, gcr-
     devel, polkit-docs, p11-kit-devel, libpeas-devel, harfbuzz-devel,
     libcanberra-devel, json-glib-devel, clutter-gst3-devel, libgdata-
     devel, gnome-bluetooth-libs-devel, gtk-doc)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
     contains desktop file(s) with a MimeType: entry.
     Note: desktop file(s) with MimeType entry in xviewer
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
     contains icons.
     Note: icons in xviewer
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[?]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in xviewer-
     devel , xviewer-doc , xviewer-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 7024640 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: xviewer-1.2.2-0.2.fc26.x86_64.rpm
          xviewer-devel-1.2.2-0.2.fc26.x86_64.rpm
          xviewer-doc-1.2.2-0.2.fc26.noarch.rpm
          xviewer-debuginfo-1.2.2-0.2.fc26.x86_64.rpm
          xviewer-1.2.2-0.2.fc26.src.rpm
xviewer.x86_64: W: spelling-error %description -l en_US gdk -> Gd
xviewer.x86_64: W: spelling-error %description -l en_US pixbuf -> pixie
xviewer.x86_64: E: zero-length /usr/share/doc/xviewer/ChangeLog
xviewer-devel.x86_64: W: spelling-error %description -l en_US developt -> develop, develops, develop t
xviewer-devel.x86_64: W: only-non-binary-in-usr-lib
xviewer-devel.x86_64: W: no-documentation
xviewer-doc.noarch: E: zero-length /usr/share/doc/xviewer/ChangeLog
xviewer.src: W: spelling-error %description -l en_US gdk -> Gd
xviewer.src: W: spelling-error %description -l en_US pixbuf -> pixie
xviewer.src:47: W: mixed-use-of-spaces-and-tabs (spaces: line 47, tab: line 1)
5 packages and 0 specfiles checked; 2 errors, 8 warnings.




Rpmlint (debuginfo)
-------------------
Checking: xviewer-debuginfo-1.2.2-0.2.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
xviewer.x86_64: W: spelling-error %description -l en_US gdk -> Gd
xviewer.x86_64: W: spelling-error %description -l en_US pixbuf -> pixie
xviewer.x86_64: E: zero-length /usr/share/doc/xviewer/ChangeLog
xviewer-devel.x86_64: W: spelling-error %description -l en_US developt -> develop, develops, develop t
xviewer-devel.x86_64: W: only-non-binary-in-usr-lib
xviewer-devel.x86_64: W: no-documentation
xviewer-doc.noarch: E: zero-length /usr/share/doc/xviewer/ChangeLog
4 packages and 0 specfiles checked; 2 errors, 5 warnings.



Requires
--------
xviewer (rpmlib, GLIBC filtered):
    /bin/sh
    libX11.so.6()(64bit)
    libatk-1.0.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo-gobject.so.2()(64bit)
    libcairo.so.2()(64bit)
    libexempi.so.3()(64bit)
    libexif.so.12()(64bit)
    libgdk-3.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libgirepository-1.0.so.1()(64bit)
    libglib-2.0.so.0()(64bit)
    libgmodule-2.0.so.0()(64bit)
    libgnome-desktop-3.so.12()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-3.so.0()(64bit)
    libjpeg.so.62()(64bit)
    libjpeg.so.62(LIBJPEG_6.2)(64bit)
    liblcms2.so.2()(64bit)
    libm.so.6()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpeas-1.0.so.0()(64bit)
    libpeas-gtk-1.0.so.0()(64bit)
    libpthread.so.0()(64bit)
    librsvg-2.so.2()(64bit)
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    libxviewer.so()(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)

xviewer-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    pkgconfig(gtk+-3.0)
    xviewer(x86-64)

xviewer-doc (rpmlib, GLIBC filtered):

xviewer-debuginfo (rpmlib, GLIBC filtered):



Provides
--------
xviewer:
    appdata()
    appdata(xviewer.appdata.xml)
    application()
    application(xviewer.desktop)
    libxviewer.so()(64bit)
    mimehandler(image/bmp)
    mimehandler(image/gif)
    mimehandler(image/jpeg)
    mimehandler(image/jpg)
    mimehandler(image/pjpeg)
    mimehandler(image/png)
    mimehandler(image/svg+xml)
    mimehandler(image/svg+xml-compressed)
    mimehandler(image/tiff)
    mimehandler(image/vnd.wap.wbmp)
    mimehandler(image/x-bmp)
    mimehandler(image/x-gray)
    mimehandler(image/x-icb)
    mimehandler(image/x-ico)
    mimehandler(image/x-pcx)
    mimehandler(image/x-png)
    mimehandler(image/x-portable-anymap)
    mimehandler(image/x-portable-bitmap)
    mimehandler(image/x-portable-graymap)
    mimehandler(image/x-portable-pixmap)
    mimehandler(image/x-xbitmap)
    mimehandler(image/x-xpixmap)
    xviewer
    xviewer(x86-64)

xviewer-devel:
    pkgconfig(xviewer)
    xviewer-devel
    xviewer-devel(x86-64)

xviewer-doc:
    xviewer-doc

xviewer-debuginfo:
    xviewer-debuginfo
    xviewer-debuginfo(x86-64)



Unversioned so-files
--------------------
xviewer: /usr/lib64/xviewer/libxviewer.so

Source checksums
----------------
https://github.com/linuxmint/xviewer/archive/1.2.2.tar.gz :
  CHECKSUM(SHA256) this package     : 0440c174f71121d2759413945ef5344fb60a554131971655fd3dfa9c46b8a7c1
  CHECKSUM(SHA256) upstream package : 0440c174f71121d2759413945ef5344fb60a554131971655fd3dfa9c46b8a7c1


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1424825
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Thank you for the review!  =)

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/xviewer

xviewer-1.4.1-1.fc25 xviewer-plugins-1.2.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e80923e4d

xviewer-1.4.1-1.fc26 xviewer-plugins-1.2.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e8283c5eac

xviewer-1.4.1-1.fc24 xviewer-plugins-1.2.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1bb452025e

xviewer-1.4.1-1.fc25, xviewer-plugins-1.2.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e80923e4d

xviewer-1.4.1-1.fc26, xviewer-plugins-1.2.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e8283c5eac

xviewer-1.4.1-1.fc24, xviewer-plugins-1.2.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1bb452025e

xviewer-1.4.1-1.fc26, xviewer-plugins-1.2.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

xviewer-1.4.1-1.fc24, xviewer-plugins-1.2.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

xviewer-1.4.1-1.fc25, xviewer-plugins-1.2.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.