Description: This package contains plugins for additional features in xviewer. Koji Build: No build. Missing dependency (xviewer). Issues: No known issues. Some minor complains from rpmlint. FAS-User: besser82 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/xviewer-plugins.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/xviewer-plugins-1.2.0-0.1.fc26.src.rpm Thanks for review in advance!
*** Bug 1359392 has been marked as a duplicate of this bug. ***
Updated Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=17989995
The srpm FTBFS testing glib-gettextize... found 2.52.0 checking for intltool >= 0.25... testing intltoolize... not found. ***Error***: You must have intltool >= 0.25 installed to build xviewer-plugins. Download the appropriate package for from your distribution or get the source tarball at http://ftp.gnome.org/pub/GNOME/sources/intltool/
Fixed FTBFS / Updated package: *** Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19419652 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/xviewer-plugins.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/xviewer-plugins-1.2.0-0.1.fc27.src.rpm
Approved ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)", "Unknown or generated". 124 files have unknown license. Detailed output of licensecheck in /home/leigh/Desktop/1424826-xviewer-plugins/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/xviewer/plugins, /usr/lib64/xviewer/plugins xviewer will own these [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/xviewer/plugins, /usr/share/xviewer/plugins xviewer will own these [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [?]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [?]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [?]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [?]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [?]: Python eggs must not download any dependencies during the build process. [?]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in xviewer- plugins-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [?]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.4.1 starting (python version = 3.6.1)... Start: init plugins INFO: selinux disabled Finish: init plugins Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.1 INFO: Mock Version: 1.4.1 Finish: chroot init Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.1 INFO: Mock Version: 1.4.1 Finish: chroot init INFO: installing package(s): /home/leigh/Desktop/1424826-xviewer-plugins/results/xviewer-plugins-1.2.0-0.1.fc27.x86_64.rpm /home/leigh/Desktop/1424826-xviewer-plugins/results/xviewer-plugins-debuginfo-1.2.0-0.1.fc27.x86_64.rpm ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M e7c9668790ec4ca18fea91c68768f4a4 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/builddir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$ --setenv=LANG=en_GB.utf8 --setenv=LC_MESSAGES=C /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 26 --disableplugin=local --setopt=deltarpm=false install /home/leigh/Desktop/1424826-xviewer-plugins/results/xviewer-plugins-1.2.0-0.1.fc27.x86_64.rpm /home/leigh/Desktop/1424826-xviewer-plugins/results/xviewer-plugins-debuginfo-1.2.0-0.1.fc27.x86_64.rpm Rpmlint ------- Checking: xviewer-plugins-1.2.0-0.1.fc27.x86_64.rpm xviewer-plugins-debuginfo-1.2.0-0.1.fc27.x86_64.rpm xviewer-plugins-1.2.0-0.1.fc27.src.rpm xviewer-plugins.x86_64: W: hidden-file-or-dir /usr/lib/.build-id xviewer-plugins.x86_64: W: hidden-file-or-dir /usr/lib/.build-id xviewer-plugins.x86_64: E: incorrect-fsf-address /usr/lib64/xviewer/plugins/export-to-folder.py xviewer-plugins.x86_64: E: incorrect-fsf-address /usr/lib64/xviewer/plugins/pythonconsole/__init__.py xviewer-plugins.x86_64: E: incorrect-fsf-address /usr/lib64/xviewer/plugins/pythonconsole/config.py xviewer-plugins.x86_64: E: incorrect-fsf-address /usr/lib64/xviewer/plugins/pythonconsole/console.py xviewer-plugins.x86_64: E: zero-length /usr/share/doc/xviewer-plugins/ChangeLog xviewer-plugins.x86_64: E: zero-length /usr/share/doc/xviewer-plugins/README xviewer-plugins.x86_64: E: zero-length /usr/share/licenses/xviewer-plugins/AUTHORS xviewer-plugins-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/xviewer-plugins-1.2.0-0.1.fc27.x86_64/plugins/exif-display/xviewer-exif-display-plugin.c xviewer-plugins-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/xviewer-plugins-1.2.0-0.1.fc27.x86_64/plugins/exif-display/xviewer-exif-display-plugin.h xviewer-plugins-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/xviewer-plugins-1.2.0-0.1.fc27.x86_64/plugins/fit-to-width/xviewer-fit-to-width-plugin.c xviewer-plugins-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/xviewer-plugins-1.2.0-0.1.fc27.x86_64/plugins/fit-to-width/xviewer-fit-to-width-plugin.h xviewer-plugins-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/xviewer-plugins-1.2.0-0.1.fc27.x86_64/plugins/postasa/xviewer-postasa-plugin.c xviewer-plugins-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/xviewer-plugins-1.2.0-0.1.fc27.x86_64/plugins/postasa/xviewer-postasa-plugin.h 3 packages and 0 specfiles checked; 13 errors, 2 warnings. Requires -------- xviewer-plugins-debuginfo (rpmlib, GLIBC filtered): xviewer-plugins (rpmlib, GLIBC filtered): /sbin/ldconfig libEGL.so.1()(64bit) libX11.so.6()(64bit) libXcomposite.so.1()(64bit) libXdamage.so.1()(64bit) libXext.so.6()(64bit) libXfixes.so.3()(64bit) libXi.so.6()(64bit) libXrandr.so.2()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libchamplain-0.12.so.0()(64bit) libchamplain-gtk-0.12.so.0()(64bit) libclutter-1.0.so.0()(64bit) libclutter-gtk-1.0.so.0()(64bit) libcogl-pango.so.20()(64bit) libcogl-path.so.20()(64bit) libcogl.so.20()(64bit) libdrm.so.2()(64bit) libexif.so.12()(64bit) libgbm.so.1()(64bit) libgdata.so.22()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libgirepository-1.0.so.1()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libjson-glib-1.0.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpeas-1.0.so.0()(64bit) libpthread.so.0()(64bit) libsoup-2.4.so.1()(64bit) libwayland-client.so.0()(64bit) libwayland-cursor.so.0()(64bit) libwayland-egl.so.1()(64bit) libwayland-server.so.0()(64bit) libxkbcommon.so.0()(64bit) libxml2.so.2()(64bit) python3(x86-64) rtld(GNU_HASH) xviewer(x86-64) Provides -------- xviewer-plugins-debuginfo: xviewer-plugins-debuginfo xviewer-plugins-debuginfo(x86-64) xviewer-plugins: libexif-display.so()(64bit) libfit-to-width.so()(64bit) liblight-theme.so()(64bit) libmap.so()(64bit) libpostasa.so()(64bit) libsend-by-mail.so()(64bit) xviewer-plugins xviewer-plugins(x86-64) Unversioned so-files -------------------- xviewer-plugins: /usr/lib64/xviewer/plugins/libexif-display.so xviewer-plugins: /usr/lib64/xviewer/plugins/libfit-to-width.so xviewer-plugins: /usr/lib64/xviewer/plugins/liblight-theme.so xviewer-plugins: /usr/lib64/xviewer/plugins/libmap.so xviewer-plugins: /usr/lib64/xviewer/plugins/libpostasa.so xviewer-plugins: /usr/lib64/xviewer/plugins/libsend-by-mail.so Source checksums ---------------- https://github.com/linuxmint/xviewer-plugins/archive/1.2.0.tar.gz#/xviewer-plugins-1.2.0.tar.gz : CHECKSUM(SHA256) this package : 92fa53fb8f3bb6b85a5f7db441cefb056ef3b7bff187fe5aa2b1a4de99fb42f0 CHECKSUM(SHA256) upstream package : 92fa53fb8f3bb6b85a5f7db441cefb056ef3b7bff187fe5aa2b1a4de99fb42f0 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1424826 Buildroot used: fedora-rawhide-x86_64
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/xviewer-plugins
xviewer-1.4.1-1.fc25 xviewer-plugins-1.2.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e80923e4d
xviewer-1.4.1-1.fc26 xviewer-plugins-1.2.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e8283c5eac
xviewer-1.4.1-1.fc24 xviewer-plugins-1.2.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1bb452025e
xviewer-1.4.1-1.fc25, xviewer-plugins-1.2.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e80923e4d
xviewer-1.4.1-1.fc26, xviewer-plugins-1.2.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e8283c5eac
xviewer-1.4.1-1.fc24, xviewer-plugins-1.2.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1bb452025e
xviewer-1.4.1-1.fc26, xviewer-plugins-1.2.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
xviewer-1.4.1-1.fc24, xviewer-plugins-1.2.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
xviewer-1.4.1-1.fc25, xviewer-plugins-1.2.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.