Bug 1424839
| Summary: | Review Request: php-rmccue-requests - Requests for PHP is a humble HTTP request library | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Randy Barlow <randy> | ||||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | rawhide | CC: | fedora, package-review | ||||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
fedora: rhel-rawhide- |
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | php-rmccue-requests-1.7.0-2.fc27 | Doc Type: | If docs needed, set a value | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2017-07-06 14:00:54 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Randy Barlow
2017-02-19 18:58:45 UTC
Created attachment 1256087 [details]
licensecheck.txt
Created attachment 1256088 [details]
phpci.log
Note: phpCompatInfo version 5.0.4 DB version 1.17.0 built Jan 24 2017
09:56:36 CET static analyze results
Created attachment 1256089 [details]
review.txt
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1424839
Buildroot used: fedora-rawhide-x86_64
instead of using pkill which raises some error on local build
+ pkill php
pkill: killing pid 1320 failed: Operation not permitted
pkill: killing pid 1328 failed: Operation not permitted
pkill: killing pid 1332 failed: Operation not permitted
pkill: killing pid 1338 failed: Operation not permitted
pkill: killing pid 1341 failed: Operation not permitted
pkill: killing pid 1357 failed: Operation not permitted
perhaps simpler to use
%{_bindir}/php -S 127.0.0.1:8080....
PHPPID=$!
kill $PHPPID
1 blocker:
[!]: License field in the package spec file matches the actual license.
See LICENSE file
# Everything is ISC, excepted IRI which is BSD
License: ISC and BSD
Hello Remi! I've fixed both of those things in this build: Spec URL: https://bowlofeggs.fedorapeople.org/php-rmccue-requests.spec SRPM URL: https://bowlofeggs.fedorapeople.org/php-rmccue-requests-1.7.0-2.fc26.src.rpm [x]: License field in the package spec file matches the actual license. === APPROVED === Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-rmccue-requests php-rmccue-requests-1.7.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-86be5251c5 php-rmccue-requests-1.7.0-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3144a999c7 php-rmccue-requests-1.7.0-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-39d19fc2a4 php-rmccue-requests-1.7.0-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-39d19fc2a4 php-rmccue-requests-1.7.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-86be5251c5 php-rmccue-requests-1.7.0-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3144a999c7 php-rmccue-requests-1.7.0-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. php-rmccue-requests-1.7.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. php-rmccue-requests-1.7.0-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |