Bug 1424839 - Review Request: php-rmccue-requests - Requests for PHP is a humble HTTP request library
Summary: Review Request: php-rmccue-requests - Requests for PHP is a humble HTTP reque...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-19 18:58 UTC by Randy Barlow
Modified: 2017-07-06 14:00 UTC (History)
2 users (show)

Fixed In Version: php-rmccue-requests-1.7.0-2.fc27
Clone Of:
Environment:
Last Closed: 2017-07-06 14:00:54 UTC
Type: ---
Embargoed:
fedora: fedora-review+
fedora: rhel-rawhide-


Attachments (Terms of Use)
licensecheck.txt (5.06 KB, text/plain)
2017-02-21 10:49 UTC, Remi Collet
no flags Details
phpci.log (30.02 KB, text/plain)
2017-02-21 10:49 UTC, Remi Collet
no flags Details
review.txt (7.47 KB, text/plain)
2017-02-21 10:50 UTC, Remi Collet
no flags Details

Description Randy Barlow 2017-02-19 18:58:45 UTC
Spec URL: https://bowlofeggs.fedorapeople.org/php-rmccue-requests.spec
SRPM URL: https://bowlofeggs.fedorapeople.org/php-rmccue-requests-1.7.0-1.fc26.src.rpm
Description: Requests for PHP simplifies how you interact with other sites and takes
away all your worries.

Requests is a HTTP library written in PHP, for human beings. It is
roughly based on the API from the excellent Requests Python library.
Requests is ISC Licensed (similar to the new BSD license) and has no
dependencies, except for PHP 5.2+.

Despite PHP's use as a language for the web, its tools for sending HTTP
requests are severely lacking. cURL has an interesting API, to say the
least, and you can't always rely on it being available. Sockets provide
only low level access, and require you to build most of the HTTP
response parsing yourself.

We all have better things to do. That's why Requests was born.
Fedora Account System Username: bowlofeggs

Comment 1 Remi Collet 2017-02-21 10:49:18 UTC
Created attachment 1256087 [details]
licensecheck.txt

Comment 2 Remi Collet 2017-02-21 10:49:48 UTC
Created attachment 1256088 [details]
phpci.log

     Note: phpCompatInfo version 5.0.4 DB version 1.17.0 built Jan 24 2017
     09:56:36 CET static analyze results

Comment 3 Remi Collet 2017-02-21 10:50:13 UTC
Created attachment 1256089 [details]
review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1424839
Buildroot used: fedora-rawhide-x86_64

Comment 4 Remi Collet 2017-02-21 10:53:45 UTC
instead of using pkill which raises some error on local build
+ pkill php
pkill: killing pid 1320 failed: Operation not permitted
pkill: killing pid 1328 failed: Operation not permitted
pkill: killing pid 1332 failed: Operation not permitted
pkill: killing pid 1338 failed: Operation not permitted
pkill: killing pid 1341 failed: Operation not permitted
pkill: killing pid 1357 failed: Operation not permitted

perhaps simpler to use

    %{_bindir}/php -S 127.0.0.1:8080....
    PHPPID=$!

    kill $PHPPID

1 blocker:

[!]: License field in the package spec file matches the actual license.
	See LICENSE file
	# Everything is ISC, excepted IRI which is BSD
	License: ISC and BSD

Comment 5 Randy Barlow 2017-03-05 17:00:42 UTC
Hello Remi!

I've fixed both of those things in this build:

Spec URL: https://bowlofeggs.fedorapeople.org/php-rmccue-requests.spec
SRPM URL: https://bowlofeggs.fedorapeople.org/php-rmccue-requests-1.7.0-2.fc26.src.rpm

Comment 6 Remi Collet 2017-03-05 17:50:58 UTC
[x]: License field in the package spec file matches the actual license.

=== APPROVED ===

Comment 7 Gwyn Ciesla 2017-03-06 15:27:14 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-rmccue-requests

Comment 8 Fedora Update System 2017-03-09 02:02:23 UTC
php-rmccue-requests-1.7.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-86be5251c5

Comment 9 Fedora Update System 2017-03-09 02:02:30 UTC
php-rmccue-requests-1.7.0-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3144a999c7

Comment 10 Fedora Update System 2017-03-09 02:02:35 UTC
php-rmccue-requests-1.7.0-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-39d19fc2a4

Comment 11 Fedora Update System 2017-03-09 14:26:31 UTC
php-rmccue-requests-1.7.0-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-39d19fc2a4

Comment 12 Fedora Update System 2017-03-09 14:58:51 UTC
php-rmccue-requests-1.7.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-86be5251c5

Comment 13 Fedora Update System 2017-03-10 23:23:04 UTC
php-rmccue-requests-1.7.0-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3144a999c7

Comment 14 Fedora Update System 2017-03-17 18:20:03 UTC
php-rmccue-requests-1.7.0-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2017-03-17 18:51:04 UTC
php-rmccue-requests-1.7.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2017-04-01 16:53:10 UTC
php-rmccue-requests-1.7.0-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.