Bug 1424879

Summary: Password written in clear text in heat-api.log with DEBUG mode [openstack-6]
Product: Red Hat OpenStack Reporter: Summer Long <slong>
Component: openstack-heatAssignee: Zane Bitter <zbitter>
Status: CLOSED ERRATA QA Contact: Amit Ugol <augol>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.0 (Juno)CC: gmollett, jjoyce, mburns, rhel-osp-director-maint, sbaker, shardy, srevivo
Target Milestone: ---Keywords: Security, Triaged, ZStream
Target Release: 6.0 (Juno)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-heat-2014.2.4-3.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1424882 1424884 1424885 1424886 1424889 (view as bug list) Environment:
Last Closed: 2017-06-14 15:31:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Summer Long 2017-02-20 02:24:19 UTC 
Description of problem:
Reported by Hans Feldt, Ericsson

Password written in clear text in heat-api.log with DEBUG mode
Because this is debug, it is a hardening issue; no CVE is attached.

Upstream bug: https://bugs.launchpad.net/heat/+bug/1664792

Affected code:
heat/common/serializers.py:
 31 class JSONResponseSerializer(object):
 32
 33 def to_json(self, data):
 34 def sanitizer(obj):
 35 if isinstance(obj, datetime.datetime):
 36 return obj.isoformat()
 37 return six.text_type(obj)
 38
 39 response = jsonutils.dumps(data, default=sanitizer)
 40 LOG.debug("JSON response : %s" % response) # <- HERE

Version-Release number of selected component (if applicable):
openstack-heat-2014.2.4-1.el7ost

Steps to Reproduce:
1. Create overcloud
2. View /var/log/heat/heat-api.log
3. Grep for AdminPassword

Actual results:
Plain text is used for passwords

Expected results:
Plain text should never be used for passwords
Comment 4 errata-xmlrpc 2017-06-14 15:31:59 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:1446