Bug 1424973

Summary: remove-brick status shows 0 rebalanced files
Product: [Community] GlusterFS Reporter: Xavi Hernandez <jahernan>
Component: distributeAssignee: Xavi Hernandez <jahernan>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.10CC: anraj, bugs, jahernan, kjohnson
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: x86_64   
OS: FreeBSD   
Whiteboard:
Fixed In Version: glusterfs-3.10.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1411228 Environment:
Last Closed: 2017-03-06 17:46:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1411228    
Bug Blocks:    

Description Xavi Hernandez 2017-02-20 08:42:44 UTC
+++ This bug was initially created as a clone of Bug #1411228 +++

+++ This bug was initially created as a clone of Bug #1373618 +++

Description of problem:  With a 2-brick distributed volume, performing a remove-brick start successfully transfers files, but remove-brick status shows 0 rebalanced-files.


Version-Release number of selected component (if applicable): CentOS 6 and FreeBSD 10 3.7.13


How reproducible: easily


Steps to Reproduce:
[root@colossus bricks]# gluster volume create removebricktest 192.168.110.1:/tank/bricks/rbt 192.168.110.2:/ftp/bricks/rbt
volume create: removebricktest: success: please start the volume to access data
[root@colossus bricks]# gluster volume start removebricktest
volume start: removebricktest: success
[root@colossus bricks]# mount -t glusterfs 192.168.110.2:/removebricktest /mnt/test
[root@colossus bricks]# cd /mnt/test
[root@colossus test]# ls
[root@colossus test]# touch file{1..100}
[root@colossus test]# ls file*| wc -l
100
[root@colossus test]# ls /ftp/bricks/rbt/file*| wc -l
28

[root@colossus2 ~]# ls /tank/bricks/rbt/file*| wc -l
      72

[root@colossus test]# gluster volume remove-brick removebricktest 192.168.110.2:/ftp/bricks/rbt start
volume remove-brick start: success
ID: c88553ba-7372-4706-bafb-b1b0e4aea9ba
[root@colossus test]# ls /ftp/bricks/rbt/file*| wc -l
28

[root@colossus2 ~]# ls /tank/bricks/rbt/file*| wc -l
     100

[root@colossus test]# gluster volume remove-brick removebricktest 192.168.110.2:/ftp/bricks/rbt status
                                    Node Rebalanced-files          size       scanned      failures       skipped               status  run time in h:m:s
                               ---------      -----------   -----------   -----------   -----------   -----------         ------------     --------------
                               localhost                0        0Bytes            28             0             0            completed        0:0:0



Actual results:
0 rebalanced-files


Expected results:
28 rebalanced-files

Additional info:

Comment 1 Worker Ant 2017-02-20 08:46:19 UTC
REVIEW: https://review.gluster.org/16686 (posix: Fix creation of files with S_ISVTX on FreeBSD) posted (#1) for review on release-3.10 by Xavier Hernandez (xhernandez)

Comment 2 Worker Ant 2017-02-20 15:42:59 UTC
COMMIT: https://review.gluster.org/16686 committed in release-3.10 by Shyamsundar Ranganathan (srangana) 
------
commit 14b26480e26dbb2e40db039c4fad95548247dddd
Author: Xavier Hernandez <xhernandez>
Date:   Tue Jan 10 17:21:56 2017 +0100

    posix: Fix creation of files with S_ISVTX on FreeBSD
    
    On FreeBSD the S_ISVTX flag is completely ignored when creating a
    regular file. Since gluster needs to create files with this flag set,
    specialy for DHT link files, it's necessary to force the flag.
    
    This fix does this by calling fchmod() after creating a file that
    must have this flag set.
    
    > Change-Id: I51eecfe4642974df6106b9084a0b144835a4997a
    > BUG: 1411228
    > Signed-off-by: Xavier Hernandez <xhernandez>
    > Reviewed-on: https://review.gluster.org/16417
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Raghavendra Bhat <raghavendra>
    > Reviewed-by: Kaleb KEITHLEY <kkeithle>
    
    Change-Id: I2087516383bd132c59bbab98eda8f2243a2163fe
    BUG: 1424973
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: https://review.gluster.org/16686
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra Bhat <raghavendra>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 3 Shyamsundar 2017-03-06 17:46:49 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html
[2] https://www.gluster.org/pipermail/gluster-users/