Bug 1425064

Summary: Set -DLIB_SUFFIX=64 in cmake macros where appropriate
Product: [Fedora] Fedora Reporter: Ville Skyttä <ville.skytta>
Component: kf5Assignee: Daniel Vrátil <me>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 26CC: jgrulich, me, rdieter
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-12 15:45:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Set -DLIB_SUFFIX=64 in cmake macros where appropriate none

Description Ville Skyttä 2017-02-20 13:36:44 UTC 
%cmake and %cmake_kd4 set this, I think %cmake_kf5 should do so
too. In absence of this, I had to do the equivalent thing manually in
the latest kid3 package in order to get it to build.
Comment 1 Ville Skyttä 2017-02-20 13:36:49 UTC 
Created attachment 1255684 [details]
Set -DLIB_SUFFIX=64 in cmake macros where appropriate
Comment 2 Ville Skyttä 2017-02-20 13:39:39 UTC 
(In reply to Ville Skyttä from comment #0)
> I had to do the equivalent thing manually in the latest kid3 package

https://src.fedoraproject.org/cgit/rpms/kid3.git/commit/?id=21e1a5905a72e14f03b7d694e357becbfdcc2700
Comment 3 Rex Dieter 2017-02-20 14:04:19 UTC 
LIB_SUFFIX is largely deprecated, there are much better options to use instead
Comment 4 Fedora End Of Life 2017-02-28 12:23:31 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.
Comment 5 Rex Dieter 2017-05-12 13:52:37 UTC 
Given comment #3 , I'm going to mark this WONTFIX
Comment 6 Ville Skyttä 2017-05-14 14:19:20 UTC 
(In reply to Rex Dieter from comment #3)
> LIB_SUFFIX is largely deprecated, there are much better options to use
> instead

Could you name some? On a quick look, it doesn't look there would be any better options available that would work with kid3.
Comment 7 Rex Dieter 2017-05-14 14:20:10 UTC 
Sure, this is probably the best one:

https://cmake.org/cmake/help/v3.0/module/GNUInstallDirs.html
Comment 8 Rex Dieter 2017-05-14 14:21:31 UTC 
But in the short-term, nothing wrong with any package continuing use of LIB_SUFFIX, I just didn't want to include that by default
Comment 9 Rex Dieter 2017-09-12 15:45:59 UTC 
reclosing wontfix, packages can continue to add/use LIB_SUFFIX themselves if needed, but it shouldn't be needed/used globally.