Bug 1425064 - Set -DLIB_SUFFIX=64 in cmake macros where appropriate
Summary: Set -DLIB_SUFFIX=64 in cmake macros where appropriate
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: kf5
Version: 26
Hardware: All
OS: All
unspecified
unspecified
Target Milestone: ---
Assignee: Daniel Vrátil
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-20 13:36 UTC by Ville Skyttä
Modified: 2017-09-12 15:45 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-09-12 15:45:59 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Set -DLIB_SUFFIX=64 in cmake macros where appropriate (1.36 KB, patch)
2017-02-20 13:36 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2017-02-20 13:36:44 UTC
%cmake and %cmake_kd4 set this, I think %cmake_kf5 should do so
too. In absence of this, I had to do the equivalent thing manually in
the latest kid3 package in order to get it to build.

Comment 1 Ville Skyttä 2017-02-20 13:36:49 UTC
Created attachment 1255684 [details]
Set -DLIB_SUFFIX=64 in cmake macros where appropriate

Comment 2 Ville Skyttä 2017-02-20 13:39:39 UTC
(In reply to Ville Skyttä from comment #0)
> I had to do the equivalent thing manually in the latest kid3 package

https://src.fedoraproject.org/cgit/rpms/kid3.git/commit/?id=21e1a5905a72e14f03b7d694e357becbfdcc2700

Comment 3 Rex Dieter 2017-02-20 14:04:19 UTC
LIB_SUFFIX is largely deprecated, there are much better options to use instead

Comment 4 Fedora End Of Life 2017-02-28 12:23:31 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 5 Rex Dieter 2017-05-12 13:52:37 UTC
Given comment #3 , I'm going to mark this WONTFIX

Comment 6 Ville Skyttä 2017-05-14 14:19:20 UTC
(In reply to Rex Dieter from comment #3)
> LIB_SUFFIX is largely deprecated, there are much better options to use
> instead

Could you name some? On a quick look, it doesn't look there would be any better options available that would work with kid3.

Comment 7 Rex Dieter 2017-05-14 14:20:10 UTC
Sure, this is probably the best one:

https://cmake.org/cmake/help/v3.0/module/GNUInstallDirs.html

Comment 8 Rex Dieter 2017-05-14 14:21:31 UTC
But in the short-term, nothing wrong with any package continuing use of LIB_SUFFIX, I just didn't want to include that by default

Comment 9 Rex Dieter 2017-09-12 15:45:59 UTC
reclosing wontfix, packages can continue to add/use LIB_SUFFIX themselves if needed, but it shouldn't be needed/used globally.


Note You need to log in before you can comment on or make changes to this bug.