Bug 1425347

Summary:	Using 'VirtIO' interface, Add Virtual Disk of Direct LUN, cannot set attribute of 'Read-Only'
Product:	[oVirt] ovirt-engine	Reporter:	Tony Wang <Sline798>
Component:	Frontend.WebAdmin	Assignee:	Tal Nisan <tnisan>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Lilach Zitnitski <lzitnits>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	4.1.1.2	CC:	amureini, bugs, lveyde, Sline798
Target Milestone:	ovirt-4.1.2	Keywords:	Regression
Target Release:	4.1.2	Flags:	rule-engine: ovirt-4.1+ rule-engine: blocker+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-05-23 08:17:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tony Wang 2017-02-21 09:21:36 UTC

Description of problem:

Using 'VirtIO' interface, Add Virtual Disk of Direct LUN, cannot set attribute of 'Read-Only'

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.Select a VM, click the sub-tab Disks;
2.Click the New button of Disks, select the Direct LUN;
3.Interface select VirtIO, check the Read-Only, configure the correct targets information;
4.Click OK button.
5.Select this disk, click the Edit button of Disks to view the information.

Actual results:
The Read-Only checkbox is unchecked.

Expected results:
The Read-Only checkbox is checked.

Additional info:

In the AbstractDiskModel, when new Disk the updateReadOnlyChangeability() setIsReadOnly() is false.

Comment 1 Yaniv Kaul 2017-02-21 10:54:29 UTC

I would think that a direct LUN's read-only attribute should be controlled by the storage, no?

Comment 2 Tony Wang 2017-02-21 11:13:03 UTC

Bug when Edit this Disk can modify the read-only attribute. 

The actual result: When Edit the Disk can set read-only attribute, but New Disk is cannot.

Comment 3 Tony Wang 2017-02-21 11:13:37 UTC

(In reply to Tony Wang from comment #2)
> When Edit this Disk can modify the read-only attribute. 
> 
> The actual result: When Edit the Disk can set read-only attribute, but New
> Disk is cannot.

Comment 4 Allon Mureinik 2017-02-23 09:15:08 UTC

(In reply to Yaniv Kaul from comment #1)
> I would think that a direct LUN's read-only attribute should be controlled
> by the storage, no?
No.
This is a flag passed down to QEMU that controls if it allows guest writes or not, regardless of whether the storage is really read-only or not.

Comment 5 Allon Mureinik 2017-02-23 09:19:36 UTC

Tal - this seems like a regression may have been introduced when these properties were moved out of the disk class (presumably, a new disk doesn't have an attachment yet, so the interface cannot be checked).
Can you take a look please?

Comment 6 Red Hat Bugzilla Rules Engine 2017-02-23 09:19:41 UTC

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 7 Lilach Zitnitski 2017-04-27 13:41:36 UTC

--------------------------------------
Tested with the following code:
----------------------------------------
rhevm-4.1.2-0.1.el7.noarch
vdsm-4.19.11-1.el7ev.x86_64
Tested with the following scenario:

Steps to Reproduce:
1.Select a VM, click the sub-tab Disks;
2.Click the New button of Disks, select the Direct LUN;
3.Interface select VirtIO, check the Read-Only, configure the correct targets information;
4.Click OK button.
5.Select this disk, click the Edit button of Disks to view the information.

Actual results:
The Read-Only checkbox is checked.

Expected results:

Moving to VERIFIED!