Description of problem: Using 'VirtIO' interface, Add Virtual Disk of Direct LUN, cannot set attribute of 'Read-Only' Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1.Select a VM, click the sub-tab Disks; 2.Click the New button of Disks, select the Direct LUN; 3.Interface select VirtIO, check the Read-Only, configure the correct targets information; 4.Click OK button. 5.Select this disk, click the Edit button of Disks to view the information. Actual results: The Read-Only checkbox is unchecked. Expected results: The Read-Only checkbox is checked. Additional info: In the AbstractDiskModel, when new Disk the updateReadOnlyChangeability() setIsReadOnly() is false.
I would think that a direct LUN's read-only attribute should be controlled by the storage, no?
Bug when Edit this Disk can modify the read-only attribute. The actual result: When Edit the Disk can set read-only attribute, but New Disk is cannot.
(In reply to Tony Wang from comment #2) > When Edit this Disk can modify the read-only attribute. > > The actual result: When Edit the Disk can set read-only attribute, but New > Disk is cannot.
(In reply to Yaniv Kaul from comment #1) > I would think that a direct LUN's read-only attribute should be controlled > by the storage, no? No. This is a flag passed down to QEMU that controls if it allows guest writes or not, regardless of whether the storage is really read-only or not.
Tal - this seems like a regression may have been introduced when these properties were moved out of the disk class (presumably, a new disk doesn't have an attachment yet, so the interface cannot be checked). Can you take a look please?
This bug report has Keywords: Regression or TestBlocker. Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.
-------------------------------------- Tested with the following code: ---------------------------------------- rhevm-4.1.2-0.1.el7.noarch vdsm-4.19.11-1.el7ev.x86_64 Tested with the following scenario: Steps to Reproduce: 1.Select a VM, click the sub-tab Disks; 2.Click the New button of Disks, select the Direct LUN; 3.Interface select VirtIO, check the Read-Only, configure the correct targets information; 4.Click OK button. 5.Select this disk, click the Edit button of Disks to view the information. Actual results: The Read-Only checkbox is checked. Expected results: Moving to VERIFIED!