Bug 1425443
| Summary: | Client's volume can change after VM migration | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Radek Duda <rduda> |
| Component: | spice-gtk | Assignee: | Default Assignee for SPICE Bugs <rh-spice-bugs> |
| Status: | CLOSED WONTFIX | QA Contact: | SPICE QE bug list <spice-qe-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 8.0 | CC: | cfergeau, dblechte, dgilbert, fziglio, mtessun, rbalakri, rduda, spice-qe-bugs, tpelka, victortoso |
| Target Milestone: | rc | ||
| Target Release: | 8.1 | ||
| Hardware: | x86_64 | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-07-09 19:12:35 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Radek Duda
2017-02-21 12:49:58 UTC
Please include the spice-server logs. If this is still happen, could be a regression as this was solved in Bug 1264107 by "sound: do not modify client state on migration":f10de4bc084fcc653340545b53782c8c4b660ea9 I can't see this being a client bug as the volume changes are messages sent by spice server based on guest's changes. Moving to spice-server for now. Created attachment 1256146 [details]
Spice-server log of migration destination host
Created attachment 1256147 [details]
spice-server log of migration source host
These are relevant packages on both hosts: spice-server-0.12.4-19.el7.x86_64 qemu-kvm-rhev-2.6.0-28.el7_3.6.x86_64 I found it is not 100% reproducible. I could not manage to reproduce the bug with rhel7.3 guest for a while. Created attachment 1256181 [details]
migration destination set G_MESSAGES_DEBUG=all and SPICE_DEBUG=1
Created attachment 1256182 [details]
migration source set G_MESSAGES_DEBUG=all and SPICE_DEBUG=1
After VM migration, the client is receiving Guest's volume for both playback and record. It should not. This can either decrease or increase client's application volume. Avoiding volume-jumps upon connection and migration was dealt in the past (Bug 1264107) so this seems to be a regression. Complementing comment #8 The bug is not just on volume but also with mute state. Changing the mute on the client and doing the migration, it should move mute back after migration. PS: I'm always referring to application's volume or mute state (in the client) Patch sent: https://lists.freedesktop.org/archives/spice-devel/2017-February/036049.html This is not a regression. I can reproduce the volume jump during migration in the RHEVM 3.6 instance at [0] which contains: spice-server-0.12.4-15.el7_2.1.x86_64 qemu-kvm-1.5.3-105.el7_2.11.x86_64 I'm removing the regression keyword here. [0] https://rhevm36.spice.brq.redhat.com not a blocker, will be included in the next server build We missed the build for this one. Does not seem important enough for exception. Moving to 7.5 and keeping the POST Rebased and sent again: https://lists.freedesktop.org/archives/spice-devel/2017-November/040791.html This needs more investigation and likely a better fix, see [0]. Moving this to 7.6 [0] https://lists.freedesktop.org/archives/spice-devel/2017-December/041047.html WIP but too late for 7.6, moving to 7.7 As per comment #17, this is client issue but not always reproducible. > The client is sending sometimes the connection_id (link message) as 0 telling > the server that this is a new connection so the server correctly send the > mute/volume information. Moving to spice-gtk in RHEL 8 Considering we have an approach to workaround it in spice (comment #16) and overview of the bug in spice-gtk done by Frediano (see link on comment #17), lets fix this in 8.3 I don't think the spice-server patch is needed, these paths should not be reached, this code
if (!red_client_during_migrate_at_target(red_client)) {
snd_set_command(scc, SND_PLAYBACK_MODE_MASK);
if (channel->volume.volume_nchannels) {
snd_set_command(scc, SND_VOLUME_MUTE_MASK);
}
}
won't set the messages to be sent if connection is a migrating one.
|