Bug 1426799

An unexpected error occured creating the scratch build: please report this issue to the-new-hotness issue tracker at https://github.com/fedora-infra/the-new-hotness/issues

*** Bug 1408250 has been marked as a duplicate of this bug. ***

Thomas, I might be able to help here a bit, but would you please be so kind to explain the current situation with ipython packaging?

This spec file _might_ be helpful to track down dependencies.

http://copr-dist-git.fedorainfracloud.org/cgit/nonamedotc/spyder3/python-ipython.git/plain/python-ipython.spec?h=f24&id=045a3391b96384d35e936b9a47bcfea307579df8


This is nowhere as thorough as the one in the repo is (this one was made using pyp2rpm), but I wanted an updated package so I made this.

pyp2rpm had some issues which I have fixed in the spec above. I have also tracked down runtime dependencies (i think something was missing).

To me, it seemed like 3.2 --> 5.x would be a massive change and although, I spent some time trying to work on ipython spec file in Fedora, I had to move on. 

Hope this spec file is useful (even a little).

Created attachment 1261347 [details]
Specfile for 5.3.0

I've took a crack at it and managed to update the spec file to 5.3.0.

The tests aren't passing (or being run), but only due to 3 unpackaged dependencies (testpath, nbformat, ipykernel)--if installed using pip, tests pass with flying colours. Does anyone have time to package those?

However, as the GUI and notebook components aren't being distributed with ipython now, I think we should wait with pushing and building it at least until review #1327979 is ready.


%changelog
* Wed Mar 08 2017 Tomas Orsava <torsava> - 5.3.0-1
- Updated to 5.3.0
- Removed the gui and notebook subpackages as they are now distributed
  separately
- Binaries ipcluster, ipcontroller and ipengine no longer exist
- Removed all patches (0-2)
- Tests don't pass, but only due to unpackaged dependencies (testpath,
  nbformat, ipykernel)

Created attachment 1261348 [details]
Diff with a full dist-git commit

Thanks!  FWIW - nbformat is packaged already.

ipykernel as well (however it doesn't work properly without new ipython)

Oh, apologies, I must have made a typo when searching for it. I'll update the attachments right now.

Awesome!

As you've "removed the gui and notebook subpackages as they are now distributed
separately", I believe something has to provide those, right?

Would it by python-notebook providing pythonX-ipython-notebook? What about the gui?

(In reply to Miro Hrončok from comment #10)
> Awesome!
> 
> As you've "removed the gui and notebook subpackages as they are now
> distributed
> separately", I believe something has to provide those, right?
> 
> Would it by python-notebook providing pythonX-ipython-notebook?

Indeed I believe that's the case.

> What about the gui?

That's the thing, so far I haven't been able to find what happened to it. (I never used it myself.) Would anyone know?

There's a problem with missing dependency of python-ipykernel and thus tests fail when run against it. I filed it as Bug #1430480.

(In reply to Tomas Orsava from comment #12)
> There's a problem with missing dependency of python-ipykernel and thus tests
> fail when run against it. I filed it as Bug #1430480.

We can BR pythonX-jupyter-client for now to workaround this?

(In reply to Miro Hrončok from comment #13)
> We can BR pythonX-jupyter-client for now to workaround this?

I mean: Can we...?

Sorry, fingers faster than mind.

(In reply to Miro Hrončok from comment #13)
> (In reply to Tomas Orsava from comment #12)
> > There's a problem with missing dependency of python-ipykernel and thus tests
> > fail when run against it. I filed it as Bug #1430480.
> 
> We can BR pythonX-jupyter-client for now to workaround this?

Indeed, works like a charm.

Created attachment 1261360 [details]
Specfile for 5.3.0

Updated test dependencies and some other things. Now it's only missing a dependency on python-testpath pending review.

Created attachment 1261361 [details]
Diff with a full dist-git commit

(In reply to Tomas Orsava from comment #11)

> 
> > What about the gui?
> 
> That's the thing, so far I haven't been able to find what happened to it. (I
> never used it myself.) Would anyone know?

Isn't ipython gui python-qtconsole? This is already packaged.

(In reply to Mukundan Ragavan from comment #18)
> (In reply to Tomas Orsava from comment #11)
> 
> > 
> > > What about the gui?
> > 
> > That's the thing, so far I haven't been able to find what happened to it. (I
> > never used it myself.) Would anyone know?
> 
> Isn't ipython gui python-qtconsole? This is already packaged.

I believe you are right. Therefore I suppose we should add Provides: pythonX-ipython-gui to that package?

(In reply to Tomas Orsava from comment #19)
> (In reply to Mukundan Ragavan from comment #18)
> > (In reply to Tomas Orsava from comment #11)
> > 
> > > 
> > > > What about the gui?
> > > 
> > > That's the thing, so far I haven't been able to find what happened to it. (I
> > > never used it myself.) Would anyone know?
> > 
> > Isn't ipython gui python-qtconsole? This is already packaged.
> 
> I believe you are right. Therefore I suppose we should add Provides:
> pythonX-ipython-gui to that package?

I suppose so. I will do that tonight.

Created attachment 1261619 [details]
Specfile for 5.3.0

Probably last round of changes:
- Added dependency on about-to-be-created python-testpath
- Modified %check section to fail the build upon test failures, as tests now run and pass with python-testpath in the buildroot
- Updated the changelog

Created attachment 1261623 [details]
Diff with a full dist-git commit

Tomas, could you please look at the docs failure/TODO?

I think adding LANG=C.utf8 might fix the error in the comment there.

python-testpath is in rawhide and in f26 buildroot (an override in action until the end of this month)

I'm hitting some missing dependency when using the new python3-ipython-sphinx:

* python3-pickleshare
* python3-prompt_toolkit

Well maybe that's missing form nbconvert.

So it's actually ipython itself:

https://github.com/ipython/ipython/blob/5.x/setup.py#L196
https://github.com/ipython/ipython/blob/5.x/setup.py#L199

Created attachment 1262976 [details]
Diff with a full dist-git commit

So I managed to fix the building of the documentation (thanks Miro for help!) and added the two missing dependencies.

pickleshare is packaged in F26+.

Both listed dependencies are.

What is the goal of keeping empty python2-ipython and python3-ipython packages? Shouldn't either the content of *-ipython-console be moved to python[23]-ipython, and Provides: python[23]-ipython-console added, or the other way around, with python[23]-ipython-console having {Provides,Obsoletes}: python[23]-ipython? (I'd prefer the first, I think people expect the main ipython package to be called something-ipython.)

I agree. Let's drop pythonX-ipython-console and provide it from pythonX-ipython (move the files there).

Created attachment 1263321 [details]
Diff with a full dist-git commit

Done: pythonX-ipython-console is no more and is provided by pythonX-ipython subpackages.

Tomas, maybe the pickleshare and prompt_toolkit needs to go to the main package and not the sphinx one? I've hit the missing dependency when using docs, but I think it's from the main package. I'll change it.

Let's do rawhide and once we have this in and all the things that provide the missing pieces, do a multi-packages update to F26.

I'll do it.

TODO:

The provides:

pythonX-notebook should provide pythonX-ipython-notebook
pythonX-qtconsole should provide pythonX-ipython-gui

They should also obsolete < 5

We shall not forget to also use the python_provide macros to provide the right python-ipython-* thing.

Thanks Tomas for the diff!

churchyard's ipython-5.3.0-1.fc27 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=869261

churchyard's ipython-5.3.0-2.fc27 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=869304

[~]$ dnf repoquery --provides python2-qtconsole --releasever=rawhide --disablerepo=\* --enablerepo=koji
application()
application(jupyter-qtconsole-2.desktop)
python-ipython-gui = 4.2.1-7.fc27
python-qtconsole = 4.2.1-7.fc27
python2-ipython-gui = 4.2.1-7.fc27
python2-qtconsole = 4.2.1-7.fc27
python2.7dist(qtconsole) = 4.2.1
python2dist(qtconsole) = 4.2.1

[~]$ dnf repoquery --obsoletes python2-qtconsole --releasever=rawhide --disablerepo=\* --enablerepo=koji
python-ipython-gui < 4.2.1-7.fc27
python-qtconsole < 4.2.1-7.fc27
python2-ipython-gui < 4

[~]$ dnf repoquery --provides python3-qtconsole --releasever=rawhide --disablerepo=\* --enablerepo=koji
application()
application(jupyter-qtconsole-3.desktop)
python3-ipython-gui = 4.2.1-7.fc27
python3-qtconsole = 4.2.1-7.fc27
python3.6dist(qtconsole) = 4.2.1
python3dist(qtconsole) = 4.2.1

[~]$ dnf repoquery --obsoletes python3-qtconsole --releasever=rawhide --disablerepo=\* --enablerepo=koji
python3-ipython-gui < 4

Excellent. Thanks for the great work folks.

I will update spyder now.

Built in F26 as ipython-5.3.0-2.fc26

Created a buildroot override (to the end of the month). The update will combine more packages later (probably tmrw).

python-notebook-4.4.1-2.fc26 ipython-5.3.0-2.fc26 python-ipykernel-4.5.2-6.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e5cf9525f

churchyard's ipython-5.3.0-3.fc27 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=869993

ipython-5.3.0-3.fc26, python-ipykernel-4.5.2-6.fc26, python-notebook-4.4.1-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e5cf9525f

churchyard's ipython-5.3.0-4.fc27 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=870172

ipython-5.3.0-4.fc26 python-ipykernel-4.5.2-6.fc26 python-notebook-4.4.1-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e5cf9525f

ipython-5.3.0-4.fc26, python-ipykernel-4.5.2-6.fc26, python-notebook-4.4.1-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e5cf9525f

(In reply to Miro Hrončok from comment #39)
> Built in F26 as ipython-5.3.0-2.fc26
> 
> Created a buildroot override (to the end of the month). The update will
> combine more packages later (probably tmrw).

This is great.

Thanks Miro!

Thomas, could you please test? It is doable from mock, instructions in bodhi comments https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e5cf9525f

ipython-5.3.0-4.fc26, python-ipykernel-4.5.2-6.fc26, python-notebook-4.4.1-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.