Bug 1426799 - ipython-5.3.0 is available
Summary: ipython-5.3.0 is available
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: ipython
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1408250 (view as bug list)
Depends On: 1379093 1430480 1430481
Blocks: 1327979
TreeView+ depends on / blocked
 
Reported: 2017-02-25 00:15 UTC by Upstream Release Monitoring
Modified: 2017-04-01 17:11 UTC (History)
14 users (show)

Fixed In Version: ipython-5.3.0-1.fc27, ipython-5.3.0-2.fc26 ipython-5.3.0-4.fc26
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-01 17:11:43 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Specfile for 5.3.0 (23.86 KB, text/x-matlab)
2017-03-08 16:51 UTC, Tomas Orsava
no flags Details
Diff with a full dist-git commit (18.97 KB, patch)
2017-03-08 16:54 UTC, Tomas Orsava
no flags Details | Diff
Specfile for 5.3.0 (24.36 KB, text/x-matlab)
2017-03-08 18:39 UTC, Tomas Orsava
no flags Details
Diff with a full dist-git commit (20.38 KB, patch)
2017-03-08 18:39 UTC, Tomas Orsava
no flags Details | Diff
Specfile for 5.3.0 (24.53 KB, text/x-matlab)
2017-03-09 15:08 UTC, Tomas Orsava
no flags Details
Diff with a full dist-git commit (21.09 KB, application/mbox)
2017-03-09 15:21 UTC, Tomas Orsava
no flags Details
Diff with a full dist-git commit (22.56 KB, patch)
2017-03-14 14:11 UTC, Tomas Orsava
no flags Details | Diff
Diff with a full dist-git commit (24.18 KB, patch)
2017-03-15 12:34 UTC, Tomas Orsava
no flags Details | Diff

Description Upstream Release Monitoring 2017-02-25 00:15:11 UTC
Latest upstream release: 5.3.0
Current version/release in rawhide: 3.2.1-12.fc26
URL: https://ipython.org/

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/1399/

Comment 1 Upstream Release Monitoring 2017-02-25 00:15:20 UTC
An unexpected error occured creating the scratch build: please report this issue to the-new-hotness issue tracker at https://github.com/fedora-infra/the-new-hotness/issues

Comment 2 Miro Hrončok 2017-03-07 20:28:07 UTC
*** Bug 1408250 has been marked as a duplicate of this bug. ***

Comment 3 Miro Hrončok 2017-03-07 20:36:44 UTC
Thomas, I might be able to help here a bit, but would you please be so kind to explain the current situation with ipython packaging?

Comment 4 Mukundan Ragavan 2017-03-08 00:52:51 UTC
This spec file _might_ be helpful to track down dependencies.

http://copr-dist-git.fedorainfracloud.org/cgit/nonamedotc/spyder3/python-ipython.git/plain/python-ipython.spec?h=f24&id=045a3391b96384d35e936b9a47bcfea307579df8


This is nowhere as thorough as the one in the repo is (this one was made using pyp2rpm), but I wanted an updated package so I made this.

pyp2rpm had some issues which I have fixed in the spec above. I have also tracked down runtime dependencies (i think something was missing).

To me, it seemed like 3.2 --> 5.x would be a massive change and although, I spent some time trying to work on ipython spec file in Fedora, I had to move on. 

Hope this spec file is useful (even a little).

Comment 5 Tomas Orsava 2017-03-08 16:51:37 UTC
Created attachment 1261347 [details]
Specfile for 5.3.0

I've took a crack at it and managed to update the spec file to 5.3.0.

The tests aren't passing (or being run), but only due to 3 unpackaged dependencies (testpath, nbformat, ipykernel)--if installed using pip, tests pass with flying colours. Does anyone have time to package those?

However, as the GUI and notebook components aren't being distributed with ipython now, I think we should wait with pushing and building it at least until review #1327979 is ready.


%changelog
* Wed Mar 08 2017 Tomas Orsava <torsava> - 5.3.0-1
- Updated to 5.3.0
- Removed the gui and notebook subpackages as they are now distributed
  separately
- Binaries ipcluster, ipcontroller and ipengine no longer exist
- Removed all patches (0-2)
- Tests don't pass, but only due to unpackaged dependencies (testpath,
  nbformat, ipykernel)

Comment 6 Tomas Orsava 2017-03-08 16:54:23 UTC
Created attachment 1261348 [details]
Diff with a full dist-git commit

Comment 7 Orion Poplawski 2017-03-08 16:58:51 UTC
Thanks!  FWIW - nbformat is packaged already.

Comment 8 Miro Hrončok 2017-03-08 17:04:07 UTC
ipykernel as well (however it doesn't work properly without new ipython)

Comment 9 Tomas Orsava 2017-03-08 17:04:07 UTC
Oh, apologies, I must have made a typo when searching for it. I'll update the attachments right now.

Comment 10 Miro Hrončok 2017-03-08 17:06:37 UTC
Awesome!

As you've "removed the gui and notebook subpackages as they are now distributed
separately", I believe something has to provide those, right?

Would it by python-notebook providing pythonX-ipython-notebook? What about the gui?

Comment 11 Tomas Orsava 2017-03-08 17:14:03 UTC
(In reply to Miro Hrončok from comment #10)
> Awesome!
> 
> As you've "removed the gui and notebook subpackages as they are now
> distributed
> separately", I believe something has to provide those, right?
> 
> Would it by python-notebook providing pythonX-ipython-notebook?

Indeed I believe that's the case.

> What about the gui?

That's the thing, so far I haven't been able to find what happened to it. (I never used it myself.) Would anyone know?

Comment 12 Tomas Orsava 2017-03-08 18:08:08 UTC
There's a problem with missing dependency of python-ipykernel and thus tests fail when run against it. I filed it as Bug #1430480.

Comment 13 Miro Hrončok 2017-03-08 18:17:28 UTC
(In reply to Tomas Orsava from comment #12)
> There's a problem with missing dependency of python-ipykernel and thus tests
> fail when run against it. I filed it as Bug #1430480.

We can BR pythonX-jupyter-client for now to workaround this?

Comment 14 Miro Hrončok 2017-03-08 18:18:30 UTC
(In reply to Miro Hrončok from comment #13)
> We can BR pythonX-jupyter-client for now to workaround this?

I mean: Can we...?

Sorry, fingers faster than mind.

Comment 15 Tomas Orsava 2017-03-08 18:37:54 UTC
(In reply to Miro Hrončok from comment #13)
> (In reply to Tomas Orsava from comment #12)
> > There's a problem with missing dependency of python-ipykernel and thus tests
> > fail when run against it. I filed it as Bug #1430480.
> 
> We can BR pythonX-jupyter-client for now to workaround this?

Indeed, works like a charm.

Comment 16 Tomas Orsava 2017-03-08 18:39:21 UTC
Created attachment 1261360 [details]
Specfile for 5.3.0

Updated test dependencies and some other things. Now it's only missing a dependency on python-testpath pending review.

Comment 17 Tomas Orsava 2017-03-08 18:39:59 UTC
Created attachment 1261361 [details]
Diff with a full dist-git commit

Comment 18 Mukundan Ragavan 2017-03-08 22:10:37 UTC
(In reply to Tomas Orsava from comment #11)

> 
> > What about the gui?
> 
> That's the thing, so far I haven't been able to find what happened to it. (I
> never used it myself.) Would anyone know?

Isn't ipython gui python-qtconsole? This is already packaged.

Comment 19 Tomas Orsava 2017-03-09 09:59:51 UTC
(In reply to Mukundan Ragavan from comment #18)
> (In reply to Tomas Orsava from comment #11)
> 
> > 
> > > What about the gui?
> > 
> > That's the thing, so far I haven't been able to find what happened to it. (I
> > never used it myself.) Would anyone know?
> 
> Isn't ipython gui python-qtconsole? This is already packaged.

I believe you are right. Therefore I suppose we should add Provides: pythonX-ipython-gui to that package?

Comment 20 Mukundan Ragavan 2017-03-09 12:20:38 UTC
(In reply to Tomas Orsava from comment #19)
> (In reply to Mukundan Ragavan from comment #18)
> > (In reply to Tomas Orsava from comment #11)
> > 
> > > 
> > > > What about the gui?
> > > 
> > > That's the thing, so far I haven't been able to find what happened to it. (I
> > > never used it myself.) Would anyone know?
> > 
> > Isn't ipython gui python-qtconsole? This is already packaged.
> 
> I believe you are right. Therefore I suppose we should add Provides:
> pythonX-ipython-gui to that package?

I suppose so. I will do that tonight.

Comment 21 Tomas Orsava 2017-03-09 15:08:36 UTC
Created attachment 1261619 [details]
Specfile for 5.3.0

Probably last round of changes:
- Added dependency on about-to-be-created python-testpath
- Modified %check section to fail the build upon test failures, as tests now run and pass with python-testpath in the buildroot
- Updated the changelog

Comment 22 Tomas Orsava 2017-03-09 15:21:27 UTC
Created attachment 1261623 [details]
Diff with a full dist-git commit

Comment 23 Miro Hrončok 2017-03-09 15:29:44 UTC
Tomas, could you please look at the docs failure/TODO?

I think adding LANG=C.utf8 might fix the error in the comment there.

Comment 24 Miro Hrončok 2017-03-09 16:01:35 UTC
python-testpath is in rawhide and in f26 buildroot (an override in action until the end of this month)

Comment 25 Miro Hrončok 2017-03-14 12:41:08 UTC
I'm hitting some missing dependency when using the new python3-ipython-sphinx:

* python3-pickleshare
* python3-prompt_toolkit

Comment 26 Miro Hrončok 2017-03-14 12:52:02 UTC
Well maybe that's missing form nbconvert.

Comment 28 Tomas Orsava 2017-03-14 14:11:55 UTC
Created attachment 1262976 [details]
Diff with a full dist-git commit

So I managed to fix the building of the documentation (thanks Miro for help!) and added the two missing dependencies.

Comment 29 Zbigniew Jędrzejewski-Szmek 2017-03-14 14:27:29 UTC
pickleshare is packaged in F26+.

Comment 30 Miro Hrončok 2017-03-14 18:55:36 UTC
Both listed dependencies are.

Comment 31 Zbigniew Jędrzejewski-Szmek 2017-03-14 19:06:43 UTC
What is the goal of keeping empty python2-ipython and python3-ipython packages? Shouldn't either the content of *-ipython-console be moved to python[23]-ipython, and Provides: python[23]-ipython-console added, or the other way around, with python[23]-ipython-console having {Provides,Obsoletes}: python[23]-ipython? (I'd prefer the first, I think people expect the main ipython package to be called something-ipython.)

Comment 32 Miro Hrončok 2017-03-14 20:14:16 UTC
I agree. Let's drop pythonX-ipython-console and provide it from pythonX-ipython (move the files there).

Comment 33 Tomas Orsava 2017-03-15 12:34:30 UTC
Created attachment 1263321 [details]
Diff with a full dist-git commit

Done: pythonX-ipython-console is no more and is provided by pythonX-ipython subpackages.

Comment 34 Miro Hrončok 2017-03-15 12:59:52 UTC
Tomas, maybe the pickleshare and prompt_toolkit needs to go to the main package and not the sphinx one? I've hit the missing dependency when using docs, but I think it's from the main package. I'll change it.

Let's do rawhide and once we have this in and all the things that provide the missing pieces, do a multi-packages update to F26.

I'll do it.

TODO:

The provides:

pythonX-notebook should provide pythonX-ipython-notebook
pythonX-qtconsole should provide pythonX-ipython-gui

They should also obsolete < 5

We shall not forget to also use the python_provide macros to provide the right python-ipython-* thing.

Thanks Tomas for the diff!

Comment 35 Upstream Release Monitoring 2017-03-15 14:20:45 UTC
churchyard's ipython-5.3.0-1.fc27 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=869261

Comment 36 Upstream Release Monitoring 2017-03-15 15:30:18 UTC
churchyard's ipython-5.3.0-2.fc27 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=869304

Comment 37 Miro Hrončok 2017-03-15 16:06:38 UTC
[~]$ dnf repoquery --provides python2-qtconsole --releasever=rawhide --disablerepo=\* --enablerepo=koji
application()
application(jupyter-qtconsole-2.desktop)
python-ipython-gui = 4.2.1-7.fc27
python-qtconsole = 4.2.1-7.fc27
python2-ipython-gui = 4.2.1-7.fc27
python2-qtconsole = 4.2.1-7.fc27
python2.7dist(qtconsole) = 4.2.1
python2dist(qtconsole) = 4.2.1

[~]$ dnf repoquery --obsoletes python2-qtconsole --releasever=rawhide --disablerepo=\* --enablerepo=koji
python-ipython-gui < 4.2.1-7.fc27
python-qtconsole < 4.2.1-7.fc27
python2-ipython-gui < 4

[~]$ dnf repoquery --provides python3-qtconsole --releasever=rawhide --disablerepo=\* --enablerepo=koji
application()
application(jupyter-qtconsole-3.desktop)
python3-ipython-gui = 4.2.1-7.fc27
python3-qtconsole = 4.2.1-7.fc27
python3.6dist(qtconsole) = 4.2.1
python3dist(qtconsole) = 4.2.1

[~]$ dnf repoquery --obsoletes python3-qtconsole --releasever=rawhide --disablerepo=\* --enablerepo=koji
python3-ipython-gui < 4

Comment 38 Mukundan Ragavan 2017-03-15 23:34:57 UTC
Excellent. Thanks for the great work folks.

I will update spyder now.

Comment 39 Miro Hrončok 2017-03-16 21:35:20 UTC
Built in F26 as ipython-5.3.0-2.fc26

Created a buildroot override (to the end of the month). The update will combine more packages later (probably tmrw).

Comment 40 Fedora Update System 2017-03-16 23:44:00 UTC
python-notebook-4.4.1-2.fc26 ipython-5.3.0-2.fc26 python-ipykernel-4.5.2-6.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e5cf9525f

Comment 41 Upstream Release Monitoring 2017-03-17 00:26:26 UTC
churchyard's ipython-5.3.0-3.fc27 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=869993

Comment 42 Fedora Update System 2017-03-17 02:21:10 UTC
ipython-5.3.0-3.fc26, python-ipykernel-4.5.2-6.fc26, python-notebook-4.4.1-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e5cf9525f

Comment 43 Upstream Release Monitoring 2017-03-17 13:21:13 UTC
churchyard's ipython-5.3.0-4.fc27 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=870172

Comment 44 Fedora Update System 2017-03-17 14:21:29 UTC
ipython-5.3.0-4.fc26 python-ipykernel-4.5.2-6.fc26 python-notebook-4.4.1-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e5cf9525f

Comment 45 Fedora Update System 2017-03-17 22:22:31 UTC
ipython-5.3.0-4.fc26, python-ipykernel-4.5.2-6.fc26, python-notebook-4.4.1-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e5cf9525f

Comment 46 Thomas Spura 2017-03-18 10:19:59 UTC
(In reply to Miro Hrončok from comment #39)
> Built in F26 as ipython-5.3.0-2.fc26
> 
> Created a buildroot override (to the end of the month). The update will
> combine more packages later (probably tmrw).

This is great.

Thanks Miro!

Comment 47 Miro Hrončok 2017-03-18 13:21:22 UTC
Thomas, could you please test? It is doable from mock, instructions in bodhi comments https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e5cf9525f

Comment 48 Fedora Update System 2017-04-01 17:11:43 UTC
ipython-5.3.0-4.fc26, python-ipykernel-4.5.2-6.fc26, python-notebook-4.4.1-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.