Bug 1428102

Summary:	libglusterfs: Change gmtime_r -> localtime_r for better log readability
Product:	[Community] GlusterFS	Reporter:	Vijay Bellur <vbellur>
Component:	core	Assignee:	bugs <bugs>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, joe
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-04-17 10:28:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vijay Bellur 2017-03-01 19:07:21 UTC

libglusterfs: Change gmtime_r -> localtime_r for better log readability

Summary:
- We should be logging in our localtime, not in GMT. Makes our logs more readable.
- This is a cherry-pick of D2464690 to 3.8.

Signature: t1:2464690:1442877302:72fa0a0d4f26569e5641c6581c352c1de32f163e

Change-Id: I046158ff91b25c8a80dd7632eece9832f691a98d
Signed-off-by: Shreyas Siravara <sshreyas>
Reviewed-on: https://review.gluster.org/16337
Reviewed-by: Kevin Vigor <kvigor>
CentOS-regression: Gluster Build System <jenkins.org>
NetBSD-regression: NetBSD Build System <jenkins.org>
Smoke: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2017-03-01 20:54:43 UTC

REVIEW: https://review.gluster.org/16818 (libglusterfs: Change gmtime_r -> localtime_r for better log readability) posted (#1) for review on master by Vijay Bellur (vbellur)

Comment 2 Joe Julian 2017-06-13 17:38:33 UTC

I disagree. When we used to do localtime collating logs between clients and servers was often impossible to get a user to do. The change to always using gmtime everywhere has made debugging much easier.

Comment 3 Yaniv Kaul 2019-04-17 10:28:58 UTC

(In reply to Joe Julian from comment #2)
> I disagree. When we used to do localtime collating logs between clients and
> servers was often impossible to get a user to do. The change to always using
> gmtime everywhere has made debugging much easier.

Closing, as the patch was also not accepted.