libglusterfs: Change gmtime_r -> localtime_r for better log readability Summary: - We should be logging in our localtime, not in GMT. Makes our logs more readable. - This is a cherry-pick of D2464690 to 3.8. Signature: t1:2464690:1442877302:72fa0a0d4f26569e5641c6581c352c1de32f163e Change-Id: I046158ff91b25c8a80dd7632eece9832f691a98d Signed-off-by: Shreyas Siravara <sshreyas> Reviewed-on: https://review.gluster.org/16337 Reviewed-by: Kevin Vigor <kvigor> CentOS-regression: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org>
REVIEW: https://review.gluster.org/16818 (libglusterfs: Change gmtime_r -> localtime_r for better log readability) posted (#1) for review on master by Vijay Bellur (vbellur)
I disagree. When we used to do localtime collating logs between clients and servers was often impossible to get a user to do. The change to always using gmtime everywhere has made debugging much easier.
(In reply to Joe Julian from comment #2) > I disagree. When we used to do localtime collating logs between clients and > servers was often impossible to get a user to do. The change to always using > gmtime everywhere has made debugging much easier. Closing, as the patch was also not accepted.