Bug 1428513

Summary:	Review Request: golang-github-calmh-du - Disk Usage Information library for Go
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Jan Chaloupka <jchaloup>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jchaloup, package-review
Target Milestone:	---	Flags:	jchaloup: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-14 17:21:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1427634

Description Fabio Valentini 2017-03-02 17:45:57 UTC

Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-calmh-du.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-calmh-du-1.0.0-1.fc25.src.rpm

Description: Disk Usage Information library for Go

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=18139640

PS: The .spec file was generated by gofed, but the sections for unit tests were removed (since there are no tests), and the package references the latest release (1.0.0) instead of git master.

Comment 1 Jan Chaloupka 2017-03-03 12:39:53 UTC

You can always keep the unit-test-devel subpackage and just set with_unit_test to 0. The tests can appear in future and it is much more easier to just set with_unit_test to 1 instead of putting back the entire subpackage.

At the same time I always keep the
Source0:        https://%{provider_prefix}/archive/v%{version}/%{repo}-%{version}.tar.gz
in a form of
Source0:        https://%{provider_prefix}/archive/%{commit}/%{repo}-%{shortcommit}.tar.gz

You will always get the same tarball as long as the commit corresponds to version. At the same time it is easier to update to non-versioned commit.

None of it is a blocker for the review.

Comment 2 Fabio Valentini 2017-03-03 13:17:47 UTC

Thanks for the review, I adapted the spec for your suggestions. The pkgdb request is submitted.

Comment 3 Gwyn Ciesla 2017-03-06 14:23:08 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-calmh-du

Comment 4 Fedora Update System 2017-03-06 16:55:42 UTC

golang-github-calmh-du-1.0.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-85847b335f

Comment 5 Fedora Update System 2017-03-06 16:56:39 UTC

golang-github-calmh-du-1.0.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e4c662af85

Comment 6 Fedora Update System 2017-03-07 01:50:59 UTC

golang-github-calmh-du-1.0.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-85847b335f

Comment 7 Fedora Update System 2017-03-07 17:53:32 UTC

golang-github-calmh-du-1.0.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e4c662af85

Comment 8 Fedora Update System 2017-03-14 17:21:33 UTC

golang-github-calmh-du-1.0.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2017-03-15 17:52:29 UTC

golang-github-calmh-du-1.0.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.