Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-calmh-du.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-calmh-du-1.0.0-1.fc25.src.rpm Description: Disk Usage Information library for Go Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=18139640 PS: The .spec file was generated by gofed, but the sections for unit tests were removed (since there are no tests), and the package references the latest release (1.0.0) instead of git master.
You can always keep the unit-test-devel subpackage and just set with_unit_test to 0. The tests can appear in future and it is much more easier to just set with_unit_test to 1 instead of putting back the entire subpackage. At the same time I always keep the Source0: https://%{provider_prefix}/archive/v%{version}/%{repo}-%{version}.tar.gz in a form of Source0: https://%{provider_prefix}/archive/%{commit}/%{repo}-%{shortcommit}.tar.gz You will always get the same tarball as long as the commit corresponds to version. At the same time it is easier to update to non-versioned commit. None of it is a blocker for the review.
Thanks for the review, I adapted the spec for your suggestions. The pkgdb request is submitted.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-calmh-du
golang-github-calmh-du-1.0.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-85847b335f
golang-github-calmh-du-1.0.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e4c662af85
golang-github-calmh-du-1.0.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-85847b335f
golang-github-calmh-du-1.0.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e4c662af85
golang-github-calmh-du-1.0.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-calmh-du-1.0.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.