Bug 1428562

Summary:	Review Request: golang-github-d4l3k-messagediff - Generate diffs of arbitrary structs in Go
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Jan Chaloupka <jchaloup>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, jchaloup, package-review
Target Milestone:	---	Flags:	jchaloup: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-14 17:22:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1427634

Description Fabio Valentini 2017-03-02 20:16:29 UTC

Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-d4l3k-messagediff.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc25.src.rpm

Description: Generate diffs of arbitrary structs in Go

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=18140814


PS: The .spec file was generated by gofed, but the version set according to the latest upstream release. All tests pass on all arches (see successful koji scratch build).

Comment 1 Jan Chaloupka 2017-03-03 13:01:16 UTC

I guess you can remove:
Provides:       golang(%{import_path}/example) = %{version}-%{release}
%gotest %{import_path}/example

Plus upgrade the installation scripts to skip the example directory.

The package is an example. Nothing that makes sense to import in other projects. Unless proven otherwise.

Otherwise LGTM. Again, the nit is not a blocker.

Comment 2 Fabio Valentini 2017-03-03 13:33:31 UTC

I removed the unnecessary Provides and the "example" folder from the package. Same links.

Comment 3 Gwyn Ciesla 2017-03-06 14:36:25 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-d4l3k-messagediff

Comment 4 Fedora Update System 2017-03-06 17:13:08 UTC

golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-01bf8d8c10

Comment 5 Fedora Update System 2017-03-06 17:14:14 UTC

golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f928a0434

Comment 6 Fedora Update System 2017-03-07 01:51:16 UTC

golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-01bf8d8c10

Comment 7 Fedora Update System 2017-03-07 17:53:47 UTC

golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f928a0434

Comment 8 Fedora Update System 2017-03-14 17:22:07 UTC

golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2017-03-15 17:52:44 UTC

golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.