Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-d4l3k-messagediff.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc25.src.rpm Description: Generate diffs of arbitrary structs in Go Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=18140814 PS: The .spec file was generated by gofed, but the version set according to the latest upstream release. All tests pass on all arches (see successful koji scratch build).
I guess you can remove: Provides: golang(%{import_path}/example) = %{version}-%{release} %gotest %{import_path}/example Plus upgrade the installation scripts to skip the example directory. The package is an example. Nothing that makes sense to import in other projects. Unless proven otherwise. Otherwise LGTM. Again, the nit is not a blocker.
I removed the unnecessary Provides and the "example" folder from the package. Same links.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-d4l3k-messagediff
golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-01bf8d8c10
golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f928a0434
golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-01bf8d8c10
golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f928a0434
golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.