Bug 1429312

Summary:	Prevent reverse heal from happening
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	replicate	Assignee:	Pranith Kumar K <pkarampu>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	3.8	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.10	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1417466	Environment:
Last Closed:	2017-03-18 10:52:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1417466
Bug Blocks:	1422942

Description Pranith Kumar K 2017-03-06 04:47:38 UTC

+++ This bug was initially created as a clone of Bug #1417466 +++

Description of problem:
There is a chance for the source brick to go down just after
the new entry is created and before source brick is marked with
necessary pending markers. If after this any I/O happens then
new entry will become source and reverse heal will happen.
To prevent this mark the pending xattrs before creating the new
entry.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2017-01-29 11:25:49 EST ---

REVIEW: https://review.gluster.org/16474 (cluster/afr: Perform new entry mark before creating new entry) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Worker Ant on 2017-02-14 12:19:07 EST ---

REVIEW: https://review.gluster.org/16474 (cluster/afr: Perform new entry mark before creating new entry) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Worker Ant on 2017-02-16 10:24:34 EST ---

COMMIT: https://review.gluster.org/16474 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 6588204568ab73bf8456ca3b2eccf2ae1182fb95
Author: Pranith Kumar K <pkarampu>
Date:   Mon Jan 23 14:58:45 2017 +0530

    cluster/afr: Perform new entry mark before creating new entry
    
    There is a chance for the source brick to go down just after
    the new entry is created and before source brick is marked with
    necessary pending markers. If after this any I/O happens then
    new entry will become source and reverse heal will happen.
    To prevent this mark the pending xattrs before creating the new
    entry.
    
    BUG: 1417466
    Change-Id: I233b87e694d32e5d734df5a83b4d2ca711c17503
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: https://review.gluster.org/16474
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Ravishankar N <ravishankar>
    Reviewed-by: Krutika Dhananjay <kdhananj>

Comment 1 Worker Ant 2017-03-06 05:48:09 UTC

REVIEW: https://review.gluster.org/16850 (cluster/afr: Perform new entry mark before creating new entry) posted (#1) for review on release-3.8 by Pranith Kumar Karampuri (pkarampu)

Comment 2 Worker Ant 2017-03-11 18:10:03 UTC

COMMIT: https://review.gluster.org/16850 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit c495bbc95cb95797bba1b62d0a49e58f2ed4bd63
Author: Pranith Kumar K <pkarampu>
Date:   Mon Jan 23 14:58:45 2017 +0530

    cluster/afr: Perform new entry mark before creating new entry
    
    There is a chance for the source brick to go down just after
    the new entry is created and before source brick is marked with
    necessary pending markers. If after this any I/O happens then
    new entry will become source and reverse heal will happen.
    To prevent this mark the pending xattrs before creating the new
    entry.
    
     >BUG: 1417466
     >Change-Id: I233b87e694d32e5d734df5a83b4d2ca711c17503
     >Signed-off-by: Pranith Kumar K <pkarampu>
     >Reviewed-on: https://review.gluster.org/16474
     >Smoke: Gluster Build System <jenkins.org>
     >NetBSD-regression: NetBSD Build System <jenkins.org>
     >CentOS-regression: Gluster Build System <jenkins.org>
     >Reviewed-by: Ravishankar N <ravishankar>
     >Reviewed-by: Krutika Dhananjay <kdhananj>
    
    BUG: 1429312
    Change-Id: Ia1bdaf9511acaeff72a336c8185a56a64ea0e2ba
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: https://review.gluster.org/16850
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Ravishankar N <ravishankar>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Niels de Vos 2017-03-18 10:52:58 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.10, please open a new bug report.

glusterfs-3.8.10 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-March/000068.html
[2] https://www.gluster.org/pipermail/gluster-users/