Bug 1431020

Summary:	Review Request: perl-Alien-pkgconf - Discover pkgconf and libpkgconf
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Alien-pkgconf-0.10-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-13 14:36:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1430837, 1431013
Bug Blocks:	1431059

Description Petr Pisar 2017-03-10 08:25:35 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Alien-pkgconf/perl-Alien-pkgconf.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Alien-pkgconf/perl-Alien-pkgconf-0.10-1.fc27.src.rpm
Description:
This Perl module provides you with the information that you need to invoke
pkgconf or link against libpkgconf. It isn't intended to be used directly,
but rather to provide the necessary package by a CPAN module that needs
libpkgconf, such as PkgConfig::LibPkgConf.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-03-13 09:17:10 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Alien-pkgconf-0.10-1.fc27.x86_64.rpm | sort | uniq -c
      1 libpkgconf-devel(x86-64) = 1.3.0
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(File::ShareDir) >= 1.102
      1 perl(File::Spec)
      1 perl(JSON::PP) >= 2.27400
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Alien-pkgconf-0.10-1.fc27.x86_64.rpm | sort | uniq -c
      1 perl(Alien::pkgconf) = 0.10
      1 perl-Alien-pkgconf = 0.10-1.fc27
      1 perl-Alien-pkgconf(x86-64) = 0.10-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Alien-pkgconf*
perl-Alien-pkgconf.src: W: spelling-error Summary(en_US) libpkgconf
perl-Alien-pkgconf.src: W: spelling-error %description -l en_US libpkgconf
perl-Alien-pkgconf.src: E: specfile-error sh: pkgconf: command not found
perl-Alien-pkgconf.x86_64: W: spelling-error Summary(en_US) libpkgconf
perl-Alien-pkgconf.x86_64: W: spelling-error %description -l en_US libpkgconf
perl-Alien-pkgconf.x86_64: E: no-binary
perl-Alien-pkgconf.x86_64: W: only-non-binary-in-usr-lib
./perl-Alien-pkgconf.spec: E: specfile-error sh: pkgconf: command not found
2 packages and 1 specfiles checked; 3 errors, 5 warnings.

'pkgconf' is listed in BR.
Explanation about full-arch package is in spec file.

Rpmlint is ok

BuildRequires are almost ok
FIX: Please add BR 'perl(File::Copy)': script/system.pl:4                   

Please correct 'FIX' issue.

Otherwise package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-03-13 13:06:55 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Alien-pkgconf

Comment 3 Petr Pisar 2017-03-13 14:36:34 UTC

Thank you for the review and the repository. I added the missing dependency.