Bug 1430837 - Review Request: perl-Test-Alien - Testing tools for Alien modules
Summary: Review Request: perl-Test-Alien - Testing tools for Alien modules
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1431020
TreeView+ depends on / blocked
 
Reported: 2017-03-09 17:05 UTC by Petr Pisar
Modified: 2017-03-10 13:46 UTC (History)
2 users (show)

Fixed In Version: perl-Test-Alien-0.12-1.fc27
Clone Of:
Environment:
Last Closed: 2017-03-10 13:46:04 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2017-03-09 17:05:59 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Test-Alien/perl-Test-Alien.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Test-Alien/perl-Test-Alien-0.12-1.fc27.src.rpm
Description:
This package provides tools for testing Alien Perl modules. It has hooks to
work easily with Alien::Base based modules, but can also be used via the
synthetic interface to test non Alien::Base based Alien modules.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-03-10 09:54:00 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test-Alien-0.12-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(:VERSION) >= 5.8.1
      1 perl(Capture::Tiny)
      1 perl(Carp)
      1 perl(Env)
      1 perl(Exporter)
      1 perl(ExtUtils::CBuilder)
      1 perl(ExtUtils::ParseXS) >= 3.21
      1 perl(File::Basename)
      1 perl(File::Copy)
      1 perl(File::Path)
      1 perl(File::Spec)
      1 perl(File::Temp)
      1 perl(File::Which) >= 1.10
      1 perl(Test2::API) >= 1.302015
      1 perl(Test2::Require)
      1 perl(Text::ParseWords)
      1 perl(base)
      1 perl(if)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Please add run-requires 'perl(Config)'
     - Test-Alien-0.12/lib/Test/Alien.pm:302

$ rpm -qp --provides perl-Test-Alien-0.12-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Test::Alien) = 0.12
      1 perl(Test::Alien::CanCompile) = 0.12
      1 perl(Test::Alien::CanPlatypus) = 0.12
      1 perl(Test::Alien::Run) = 0.12
      1 perl(Test::Alien::Synthetic) = 0.12
      1 perl-Test-Alien = 0.12-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Test-Alien*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please correct 'FIX' issue.

Otherwise package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-03-10 13:25:42 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Test-Alien

Comment 3 Petr Pisar 2017-03-10 13:46:04 UTC
Thank you for the review and the repository. I added the dependency.


Note You need to log in before you can comment on or make changes to this bug.