Bug 1431729

Summary:	Review Request: perl-Class-Refresh - Refresh your classes during run time
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Class-Refresh-0.07-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-16 13:52:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1431708
Bug Blocks:

Description Petr Pisar 2017-03-13 16:23:02 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Class-Refresh/perl-Class-Refresh.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Class-Refresh/perl-Class-Refresh-0.07-1.fc27.src.rpm
Description:
During development, it is fairly common to cycle between writing code and
testing that code. Generally the testing happens within the test suite, but
frequently it is more convenient to test things by hand when tracking down
a bug, or when doing some exploratory coding. In many situations, however,
this becomes inconvenient - for instance, in a REPL, or in a stateful web
application, restarting from the beginning after every code change can get
pretty tedious. This module allows you to reload your application classes
on the fly, so that the code/test cycle becomes a lot easier.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-03-15 16:30:43 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Class-Refresh-0.07-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(B)
      1 perl(Carp)
      1 perl(Class::Load)
      1 perl(Class::Unload)
      1 perl(Devel::OverrideGlobalRequire)
      1 perl(Try::Tiny)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Class-Refresh-0.07-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Class::Refresh) = 0.07
      1 perl-Class-Refresh = 0.07-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Class-Refresh*
perl-Class-Refresh.noarch: W: spelling-error %description -l en_US stateful -> tasteful, wasteful, fateful
perl-Class-Refresh.src: W: spelling-error %description -l en_US stateful -> tasteful, wasteful, fateful
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

BuildRequires are ok
TODO: To run all optional tests please add build-requires
      - perl(Test::Moose) - t/moose-metaclasses.t:5

Please consider fixing 'TODO' item.

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-03-16 13:20:09 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Class-Refresh

Comment 3 Petr Pisar 2017-03-16 13:52:17 UTC

Thank you for the review and the repository. I added the optional dependency.