Bug 1431708 - Review Request: perl-Devel-OverrideGlobalRequire - Override CORE::GLOBAL::require safely
Summary: Review Request: perl-Devel-OverrideGlobalRequire - Override CORE::GLOBAL::req...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1431729
TreeView+ depends on / blocked
 
Reported: 2017-03-13 16:05 UTC by Petr Pisar
Modified: 2017-03-15 15:01 UTC (History)
2 users (show)

Fixed In Version: perl-Devel-OverrideGlobalRequire-0.001-1.fc27
Clone Of:
Environment:
Last Closed: 2017-03-15 15:01:51 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2017-03-13 16:05:14 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Devel-OverrideGlobalRequire/perl-Devel-OverrideGlobalRequire.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Devel-OverrideGlobalRequire/perl-Devel-OverrideGlobalRequire-0.001-1.fc27.src.rpm
Description:
This Perl module overrides CORE::GLOBAL::require with a code reference in a way
that plays nice with any existing overloading and ensures the right calling
package is in scope.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-03-14 15:30:23 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Devel-OverrideGlobalRequire-0.001-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Devel-OverrideGlobalRequire-0.001-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Devel::OverrideGlobalRequire) = 0.001
      1 perl-Devel-OverrideGlobalRequire = 0.001-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Devel-OverrideGlobalRequire*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2017-03-15 12:37:44 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Devel-OverrideGlobalRequire

Comment 3 Petr Pisar 2017-03-15 15:01:51 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.