Bug 1431986

Summary: expand_dfs plugin read_target_host() parameters
Product: Red Hat Enterprise Linux 7 Reporter: Andrey Bondarenko <abondare>
Component: sambaAssignee: Andreas Schneider <asn>
Status: CLOSED ERRATA QA Contact: Andrej Dzilský <adzilsky>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 7.3CC: abondare, adzilsky, asn, gdeschner, jarrpa, rhack
Target Milestone: rcFlags: abondare: needinfo+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: samba-4.6.2-4.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1432911 (view as bug list) Environment:
Last Closed: 2017-08-01 18:21:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1432911    
Attachments:
Description Flags
msdfs.patch none

Description Andrey Bondarenko 2017-03-14 08:36:20 UTC
Description of problem:

The ip address of the remote client was used as the map filename.

[2017/03/06 16:42:39.859984,  0] ../source3/modules/vfs_expand_msdfs.c:56(read_target_host)
  can't open IP map 10.100.0.204. Error No such file or directory


In the vfs_expand_mfs.c file, we could  see that the parameters are reversed in the function definition and function call.
See below.

targethost = read_target_host(
        ctx, raddr, mapfilename);


static char *read_target_host(TALLOC_CTX *ctx, const char *mapfile,
                  const char *clientaddr)

the patch is simple:

diff source3/modules/vfs_expand_msdfs.c ../samba-4.2.10/source3/modules/vfs_expand_msdfs.c
151c151
<               ctx, mapfilename, raddr);
---
>               ctx, raddr, mapfilename);


Version-Release number of selected component (if applicable):


[root@mediasrv01 samba]# rpm -qa | grep samba
samba-common-tools-4.2.10-6.2.el7_2.x86_64
samba-client-4.2.10-6.2.el7_2.x86_64
samba-common-libs-4.2.10-6.2.el7_2.x86_64
samba-common-4.2.10-6.2.el7_2.noarch
samba-vfs-evs-1.0.5-0.el7.x86_64
samba-client-libs-4.2.10-6.2.el7_2.x86_64
pcp-pmda-samba-3.10.6-2.el7.x86_64
samba-python-4.2.10-6.2.el7_2.x86_64
samba-4.2.10-6.2.el7_2.x86_64
samba-libs-4.2.10-6.2.el7_2.x86_64
[root@mediasrv01 samba]# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 7.2 (Maipo)

How reproducible:

Mount DFS share.


Actual results:

  can't open IP map 10.100.0.204. Error No such file or directory


Expected results:

 working share

Comment 9 Andreas Schneider 2017-03-21 14:47:51 UTC
Created attachment 1265102 [details]
msdfs.patch

Comment 10 Andreas Schneider 2017-03-21 14:48:36 UTC
Can you please test with the patch attached to this bug?

Comment 11 Andreas Schneider 2017-04-05 09:08:52 UTC
*** Bug 1432911 has been marked as a duplicate of this bug. ***

Comment 17 errata-xmlrpc 2017-08-01 18:21:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:1950