Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1431986 - expand_dfs plugin read_target_host() parameters
expand_dfs plugin read_target_host() parameters
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: samba (Show other bugs)
7.3
All Linux
unspecified Severity medium
: rc
: ---
Assigned To: Andreas Schneider
Andrej Dzilský
:
: 1432911 (view as bug list)
Depends On:
Blocks: 1432911
  Show dependency treegraph
 
Reported: 2017-03-14 04:36 EDT by Andrey Bondarenko
Modified: 2017-08-01 14:21 EDT (History)
6 users (show)

See Also:
Fixed In Version: samba-4.6.2-4.el7
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1432911 (view as bug list)
Environment:
Last Closed: 2017-08-01 14:21:34 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
abondare: needinfo+


Attachments (Terms of Use)
msdfs.patch (5.43 KB, patch)
2017-03-21 10:47 EDT, Andreas Schneider
no flags Details | Diff


External Trackers
Tracker ID Priority Status Summary Last Updated
Samba Project 12687 None None None 2017-03-14 11:23 EDT
Red Hat Product Errata RHSA-2017:1950 normal SHIPPED_LIVE Low: samba security, bug fix, and enhancement update 2017-08-01 14:09:24 EDT

  None (edit)
Description Andrey Bondarenko 2017-03-14 04:36:20 EDT
Description of problem:

The ip address of the remote client was used as the map filename.

[2017/03/06 16:42:39.859984,  0] ../source3/modules/vfs_expand_msdfs.c:56(read_target_host)
  can't open IP map 10.100.0.204. Error No such file or directory


In the vfs_expand_mfs.c file, we could  see that the parameters are reversed in the function definition and function call.
See below.

targethost = read_target_host(
        ctx, raddr, mapfilename);


static char *read_target_host(TALLOC_CTX *ctx, const char *mapfile,
                  const char *clientaddr)

the patch is simple:

diff source3/modules/vfs_expand_msdfs.c ../samba-4.2.10/source3/modules/vfs_expand_msdfs.c
151c151
<               ctx, mapfilename, raddr);
---
>               ctx, raddr, mapfilename);


Version-Release number of selected component (if applicable):


[root@mediasrv01 samba]# rpm -qa | grep samba
samba-common-tools-4.2.10-6.2.el7_2.x86_64
samba-client-4.2.10-6.2.el7_2.x86_64
samba-common-libs-4.2.10-6.2.el7_2.x86_64
samba-common-4.2.10-6.2.el7_2.noarch
samba-vfs-evs-1.0.5-0.el7.x86_64
samba-client-libs-4.2.10-6.2.el7_2.x86_64
pcp-pmda-samba-3.10.6-2.el7.x86_64
samba-python-4.2.10-6.2.el7_2.x86_64
samba-4.2.10-6.2.el7_2.x86_64
samba-libs-4.2.10-6.2.el7_2.x86_64
[root@mediasrv01 samba]# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 7.2 (Maipo)

How reproducible:

Mount DFS share.


Actual results:

  can't open IP map 10.100.0.204. Error No such file or directory


Expected results:

 working share
Comment 9 Andreas Schneider 2017-03-21 10:47 EDT
Created attachment 1265102 [details]
msdfs.patch
Comment 10 Andreas Schneider 2017-03-21 10:48:36 EDT
Can you please test with the patch attached to this bug?
Comment 11 Andreas Schneider 2017-04-05 05:08:52 EDT
*** Bug 1432911 has been marked as a duplicate of this bug. ***
Comment 17 errata-xmlrpc 2017-08-01 14:21:34 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:1950

Note You need to log in before you can comment on or make changes to this bug.