Bug 1432221

Summary: oadm diagnostics checking the wrong things
Product: OpenShift Container Platform Reporter: Ryan Cook <rcook>
Component: ocAssignee: Luke Meyer <lmeyer>
Status: CLOSED DUPLICATE QA Contact: Xingxing Xia <xxia>
Severity: low Docs Contact:
Priority: unspecified    
Version: 3.4.1CC: aos-bugs, jkaur, jokerman, lmeyer, mmccomas
Target Milestone: ---   
Target Release: 3.7.z   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-08 21:40:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ryan Cook 2017-03-14 19:59:22 UTC
Description of problem: Oadm diagnostics is attempting to check for origin items against OCP.


Version-Release number of selected component (if applicable):
(version v3.4.1.7)

How reproducible:
Login to an openshift master through ssh


Steps to Reproduce:
1. sudo su -
2. oadm diagnostics


Actual results:
ERROR: [DS1004 from controller openshift/origin/pkg/diagnostics/systemd/locate_units.go]
       Unable to run `systemctl show origin-master`: exit status 1
       Cannot analyze systemd units.
       
ERROR: [DS1004 from controller openshift/origin/pkg/diagnostics/systemd/locate_units.go]
       Unable to run `systemctl show origin-node`: exit status 1
       Cannot analyze systemd units.
       
ERROR: [DS1004 from controller openshift/origin/pkg/diagnostics/systemd/locate_units.go]
       Unable to run `systemctl show kubernetes`: exit status 1
       Cannot analyze systemd units.
       
[Note] Running diagnostic: ConfigContexts[default/openshift-master-sysdeseng-com:443/system:admin]
       Description: Validate client config context is complete and has connectivity



Expected results:
ERROR: [DS1004 from controller openshift/origin/pkg/diagnostics/systemd/locate_units.go]
       Unable to run `systemctl show atomic-openshift-master`:
       
ERROR: [DS1004 from controller openshift/origin/pkg/diagnostics/systemd/locate_units.go]
       Unable to run `systemctl show atomic-openshift-node`: 
       
ERROR: [DS1004 from controller openshift/origin/pkg/diagnostics/systemd/locate_units.go]
       Unable to run `systemctl show kubernetes`: REMOVED
       


Additional info:

Comment 1 Rodolfo Carvalho 2017-06-29 12:09:39 UTC
Luke, could you please have a look? Maybe this has been fixed and needs a backport? The original report was OCP 3.4.

Comment 4 Luke Meyer 2018-02-08 21:40:42 UTC
This was not a bug in OCP per se. The diagnostics make no assumptions about whether to look for Origin or OCP units; they look for both. The problem seen here is that systemd had a regression in how it responded when asked about an unknown unit; until the fix in https://bugzilla.redhat.com/show_bug.cgi?id=1380259 was released it exited with an error code. The solution is to use an updated systemd.

This problem was originally noted in https://bugzilla.redhat.com/show_bug.cgi?id=1378883

*** This bug has been marked as a duplicate of bug 1378883 ***