Bug 1432283

Summary: pcs hides debugging options for (some?) fencing devices
Product: Red Hat Enterprise Linux 7 Reporter: Andrew Beekhof <abeekhof>
Component: pcsAssignee: Tomas Jelinek <tojeline>
Status: CLOSED ERRATA QA Contact: cluster-qe <cluster-qe>
Severity: medium Docs Contact: Steven J. Levine <slevine>
Priority: medium    
Version: 7.3CC: cfeist, cluster-maint, idevat, omular, rsteiger, tojeline
Target Milestone: rcKeywords: EasyFix
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pcs-0.9.160-1.el7 Doc Type: Bug Fix
Doc Text:
It is now possible to enable stonith agent debugging without specifying the `--force` flag Previously, attempting to enable debugging of a stonith agent by setting the `debug` or `verbose` parameters required that the user specify the `--force` flag. With this fix, using the `--force` flag is no longer necessary.
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-10 15:39:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
proposed fix + tests none

Description Andrew Beekhof 2017-03-15 01:17:48 UTC
Description of problem:

[root@overcloud-controller-0 heat-admin]# crm_resource --show-metadata stonith:fence_ipmilan | grep -e verbose -e debug
    <parameter name="verbose" unique="0" required="0">
    <parameter name="debug" unique="0" required="0">
      <getopt mixed="-d [pathtodebugfile]           Path to debug file"/>
        Path to debug file
[root@overcloud-controller-0 heat-admin]# pcs stonith describe fence_ipmilan | grep -e verbose -e debug
[root@overcloud-controller-0 heat-admin]#


Version-Release number of selected component (if applicable):

pcs-0.9.152-10.el7.centos.3.x86_64

How reproducible:

100%

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Tomas Jelinek 2017-06-12 11:33:14 UTC
Created attachment 1287034 [details]
proposed fix + tests

Comment 4 Ivan Devat 2017-10-11 07:53:37 UTC
After Fix:

[vm-rhel72-1 ~] $ rpm -q pcs
pcs-0.9.160-1.el7.x86_64

[vm-rhel72-1 ~] $ pcs stonith create S fence_apc login=l ipaddr=i verbose=v debug=d
[vm-rhel72-1 ~] $ pcs cluster cib --config | grep 'id="S"' -A10
    <primitive class="stonith" id="S" type="fence_apc">
      <instance_attributes id="S-instance_attributes">
        <nvpair id="S-instance_attributes-debug" name="debug" value="d"/>
        <nvpair id="S-instance_attributes-ipaddr" name="ipaddr" value="i"/>
        <nvpair id="S-instance_attributes-login" name="login" value="l"/>
        <nvpair id="S-instance_attributes-verbose" name="verbose" value="v"/>
      </instance_attributes>
      <operations>
        <op id="S-monitor-interval-60s" interval="60s" name="monitor"/>
      </operations>
    </primitive>

Comment 11 errata-xmlrpc 2018-04-10 15:39:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0866