Bug 1433062

Summary:	GCE Region is useless in GCE Provider
Product:	Red Hat CloudForms Management Engine	Reporter:	Matouš Mojžíš <mmojzis>
Component:	Providers	Assignee:	Tomas Coufal <tcoufal>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Matouš Mojžíš <mmojzis>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.8.0	CC:	bsorota, jfrey, jhardy, mshriver, obarenbo, simaishi, tcoufal
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	ui:provider:gce
Fixed In Version:	5.10.0.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1552305 (view as bug list)		Environment:
Last Closed:	2019-02-11 13:55:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1552305

Description Matouš Mojžíš 2017-03-16 16:56:32 UTC

Description of problem:


Version-Release number of selected component (if applicable):
5.8.0.4

How reproducible:
Always

Steps to Reproduce:
1. Try to add a GCE provider
2.
3.

Actual results:
GCE Region is mandatory for adding provider, but it is not used anywhere and doesn't have impact on anything. I can access all the data from all the regions.
It can be somehow confusing to have this field when adding provider.

Expected results:
Delete this field from provider add dialog.

Additional info:

Comment 3 Adam Grare 2017-04-10 20:47:02 UTC

The region isn't used to connect to the provider, I had talked with the automate team about using it as the default region for provisioning when using auto-placement but it doesn't appear to be implemented right now.

Interestingly it looks like Lars didn't intend for the region to be require:
https://github.com/ManageIQ/manageiq/blob/fine/app/models/manageiq/providers/google/cloud_manager.rb#L40-L42

However no-one is checking that flag.

I could certainly see making the region optional in the UI and changing the display name to "Default region" or removing it entirely since it isn't needed.

Comment 4 Bronagh Sorota 2018-02-22 18:51:39 UTC

*** Bug 1544547 has been marked as a duplicate of this bug. ***

Comment 5 Bronagh Sorota 2018-02-22 18:53:50 UTC

*** Bug 1547465 has been marked as a duplicate of this bug. ***

Comment 6 Bronagh Sorota 2018-02-23 17:02:18 UTC

*** Bug 1545767 has been marked as a duplicate of this bug. ***

Comment 7 Tomas Coufal 2018-02-26 14:00:50 UTC

Fix removes the field if a flag `:region_required? == false` is present in the provider.

https://github.com/ManageIQ/manageiq-ui-classic/pull/3471

Currently on review.

Comment 8 Tomas Coufal 2018-02-28 18:32:45 UTC

Merged.

Comment 9 Tomas Coufal 2018-03-02 13:50:38 UTC

Some more changes in provider itself are required. Back to ON_DEV.

Comment 10 Tomas Coufal 2018-03-02 14:40:38 UTC

Ok, so finally we (me, agrare, lsmola) rather decided to remove the regions at all, since they are really no use in GCE now. They were used only for ems description and since this was also incorrect, it's better to have them removed completely.

PR: https://github.com/ManageIQ/manageiq-providers-google/pull/52

Comment 11 Tomas Coufal 2018-03-06 15:56:05 UTC

Merged. The Regions have been disabled completely from GCE provider.

Cheers, Tom

Comment 12 Tomas Coufal 2018-03-06 15:56:31 UTC

s/disabled/removed/

Comment 23 Bronagh Sorota 2018-04-17 11:41:59 UTC

*** Bug 1547465 has been marked as a duplicate of this bug. ***

Comment 24 Matouš Mojžíš 2018-06-19 16:59:06 UTC

One time issue. Setting qe_test_coverage flag to -.

Comment 25 Matouš Mojžíš 2018-06-21 16:16:47 UTC

Verified in 5.10.0.1. Region field is not displayed in gce provider add form.