Description of problem: Version-Release number of selected component (if applicable): 5.8.0.4 How reproducible: Always Steps to Reproduce: 1. Try to add a GCE provider 2. 3. Actual results: GCE Region is mandatory for adding provider, but it is not used anywhere and doesn't have impact on anything. I can access all the data from all the regions. It can be somehow confusing to have this field when adding provider. Expected results: Delete this field from provider add dialog. Additional info:
The region isn't used to connect to the provider, I had talked with the automate team about using it as the default region for provisioning when using auto-placement but it doesn't appear to be implemented right now. Interestingly it looks like Lars didn't intend for the region to be require: https://github.com/ManageIQ/manageiq/blob/fine/app/models/manageiq/providers/google/cloud_manager.rb#L40-L42 However no-one is checking that flag. I could certainly see making the region optional in the UI and changing the display name to "Default region" or removing it entirely since it isn't needed.
*** Bug 1544547 has been marked as a duplicate of this bug. ***
*** Bug 1547465 has been marked as a duplicate of this bug. ***
*** Bug 1545767 has been marked as a duplicate of this bug. ***
Fix removes the field if a flag `:region_required? == false` is present in the provider. https://github.com/ManageIQ/manageiq-ui-classic/pull/3471 Currently on review.
Merged.
Some more changes in provider itself are required. Back to ON_DEV.
Ok, so finally we (me, agrare, lsmola) rather decided to remove the regions at all, since they are really no use in GCE now. They were used only for ems description and since this was also incorrect, it's better to have them removed completely. PR: https://github.com/ManageIQ/manageiq-providers-google/pull/52
Merged. The Regions have been disabled completely from GCE provider. Cheers, Tom
s/disabled/removed/
One time issue. Setting qe_test_coverage flag to -.
Verified in 5.10.0.1. Region field is not displayed in gce provider add form.