Bug 1433623
| Summary: | Review Request: python-ufolib - A low-level UFO reader and writer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Athos Ribeiro <athoscribeiro> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-04-04 16:02:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1433626, 1433744, 1433745, 1433760 | ||
|
Description
Athos Ribeiro
2017-03-18 21:31:16 UTC
I decided to reintroduce the testdata, since they are just sources examples for running the test suite. Spec URL: https://athoscr.fedorapeople.org/packaging/python-ufoLib.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/python-ufoLib-2.0.0-2.fc25.src.rpm koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18461040 Adding a few improvements to the spec file Spec URL: https://athoscr.fedorapeople.org/packaging/python-ufoLib.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/python-ufoLib-2.0.0-3.fc25.src.rpm "Package names should be in lower case" [https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#General_Naming]. You don't need %global sum, you can just put the text in the first Summary, and use %summary in subsequent ones. - package name not OK + license is acceptable (BSD 3 clause) + license is specified correctly + latest version + modern python packaging template is used + %python_provide are present + no scriptlets necessary + %check is present and passes + BR/R/P appear correct fedora-review reports no issues. rpmlint: packages and 0 specfiles checked; 0 errors, 0 warnings. Looks good except for the lack of lowercaseness of the name ;) Package renamed and sum global removed Spec URL: https://athoscr.fedorapeople.org/packaging/python-ufolib.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/python-ufolib-2.0.0-4.fc25.src.rpm Package is APPROVED. Thank you for the review! :) Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-ufolib python-ufolib-2.0.0-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2e91e29206 python-ufolib-2.0.0-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2e91e29206 python-ufolib-2.0.0-4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |