Bug 1433626 - Review Request: python-defcon - A set of flexible objects for representing UFO data
Summary: Review Request: python-defcon - A set of flexible objects for representing UF...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1433623
Blocks: 1433744 1433757
TreeView+ depends on / blocked
 
Reported: 2017-03-18 22:39 UTC by Athos Ribeiro
Modified: 2017-04-10 16:01 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-10 16:01:28 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Athos Ribeiro 2017-03-18 22:39:20 UTC
Spec URL: https://athoscr.fedorapeople.org/packaging/python-defcon.spec
SRPM URL: https://athoscr.fedorapeople.org/packaging/python-defcon-0.2.5-1.fc25.src.rpm

Description:
Defcon is a set of UFO based objects optimized for use in font editing
applications.
Defcon implements UFO3 as described by the UFO font format. If needed, the
ufo2-deprecated branch has the older, UFO2, version of Defcon.

Fedora Account System Username: athoscr

Comment 1 Zbigniew Jędrzejewski-Szmek 2017-03-19 13:09:05 UTC
You don't need %global sum, you can just put the text in the first Summary, and use %summary in subsequent ones.

"Defcon implements UFO3 as described by the UFO font format. If needed, the
ufo2-deprecated branch has the older, UFO2, version of Defcon." — is this comment applicable to the Fedora package in any way?

I think UFO should be expanded, since not everybody knows which UFO you're talking about ("...set of UFO (Universal Font Format) objects...").

Comment 2 Zbigniew Jędrzejewski-Szmek 2017-03-19 13:37:22 UTC
fedora-review reports no issues.

+ package name is OK
+ license is acceptable (MIT)
+ license is specified correctly
+ latest version
+ modern python packaging template is used
+ %python_provide are present
+ no scriptlets necessary
+ %check is present and passes
+ BR/R/P appear correct

Package is APPROVED. (ufoLib dep might need changing to lowercase. Also see notes in previous comment.)

Comment 3 Athos Ribeiro 2017-03-19 13:52:45 UTC
Thanks for the review!

Fixed the summary and the description

Spec URL: https://athoscr.fedorapeople.org/packaging/python-defcon.spec

SRPM URL: https://athoscr.fedorapeople.org/packaging/python-defcon-0.2.5-2.fc25.src.rpm

Comment 4 Gwyn Ciesla 2017-03-20 13:10:35 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-defcon

Comment 5 Fedora Update System 2017-04-05 13:58:12 UTC
python-defcon-0.3.2-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-cdf3a8ca0d

Comment 6 Fedora Update System 2017-04-06 22:21:41 UTC
python-defcon-0.3.2-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cdf3a8ca0d

Comment 7 Fedora Update System 2017-04-10 16:01:28 UTC
python-defcon-0.3.2-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.