Bug 1433626
| Summary: | Review Request: python-defcon - A set of flexible objects for representing UFO data | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Athos Ribeiro <athoscribeiro> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-04-10 16:01:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1433623 | ||
| Bug Blocks: | 1433744, 1433757 | ||
|
Description
Athos Ribeiro
2017-03-18 22:39:20 UTC
You don't need %global sum, you can just put the text in the first Summary, and use %summary in subsequent ones.
"Defcon implements UFO3 as described by the UFO font format. If needed, the
ufo2-deprecated branch has the older, UFO2, version of Defcon." — is this comment applicable to the Fedora package in any way?
I think UFO should be expanded, since not everybody knows which UFO you're talking about ("...set of UFO (Universal Font Format) objects...").
fedora-review reports no issues. + package name is OK + license is acceptable (MIT) + license is specified correctly + latest version + modern python packaging template is used + %python_provide are present + no scriptlets necessary + %check is present and passes + BR/R/P appear correct Package is APPROVED. (ufoLib dep might need changing to lowercase. Also see notes in previous comment.) Thanks for the review! Fixed the summary and the description Spec URL: https://athoscr.fedorapeople.org/packaging/python-defcon.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/python-defcon-0.2.5-2.fc25.src.rpm Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-defcon python-defcon-0.3.2-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-cdf3a8ca0d python-defcon-0.3.2-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cdf3a8ca0d python-defcon-0.3.2-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |