Bug 1433937

Summary:	virt-inspector can't get icon info from altlinux-centaurus
Product:	Red Hat Enterprise Linux 7	Reporter:	Xianghua Chen <xchen>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	7.4	CC:	ptoscano, wshi, yoguo
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libguestfs-1.36.3-1.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-01 22:13:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1359086
Bug Blocks:

Description Xianghua Chen 2017-03-20 12:17:06 UTC

Description of problem:
virt-inspector can't get icon info from altlinux-centaurus.

Version-Release number of selected component (if applicable):
virt-dib-1.36.2-2.el7.x86_64

How reproducible:
100%

Steps:
1. Prepare one altlinux-centaurus guest image:
altlinux-centaurus-x86_64.qcow2
2. Inspect it:
# virt-inspector -a altlinux-centaurus-x86_64.qcow2


Actual results:
There is no icon info like:
<icon>... ... </icon>


Expected results:
There should be icon info in the xml output.


Additional info:

Comment 1 Xianghua Chen 2017-03-20 12:20:06 UTC

Sorry, the version should be:

Version-Release number of selected component (if applicable):
libguestfs-1.36.2-2.el7.x86_64

Comment 2 Pino Toscano 2017-03-20 12:52:22 UTC

Easy fix, luckly there are logos also in other system packages -- patch posted:
  https://www.redhat.com/archives/libguestfs/2017-March/msg00222.html

Comment 3 Pino Toscano 2017-03-20 13:28:51 UTC

Fixed with
https://github.com/libguestfs/libguestfs/commit/bc54e0d605682385f460c6e90ba87c5a48f8077e
which is in libguestfs >= 1.37.7.

Comment 5 Xianghua Chen 2017-03-24 06:02:09 UTC

Failed with the following package:
libguestfs-1.36.2-3.el7.x86_64

Steps:
1. Prepare one altlinux-centaurus guest image:
altlinux-centaurus-x86_64.qcow2
2. Inspect it:
# virt-inspector -a altlinux-centaurus-x86_64.qcow2

Still no <icon>. 
Also failed for altlinux-simply-x86_64.qcow2 this time.

P.S.:
I have checked the patch that you are using: /usr/share/icons/hicolor/64x64/apps/altlinux.png
But actually there is no that file, I guestmount it and find that there are only:
# find /mnt/test/usr/share/icons/hicolor/  -name altlinux.png
/mnt/test/usr/share/icons/hicolor/32x32/apps/altlinux.png
/mnt/test/usr/share/icons/hicolor/16x16/apps/altlinux.png
/mnt/test/usr/share/icons/hicolor/48x48/apps/altlinux.png

So does the altlinux-simply image.

Comment 6 YongkuiGuo 2017-03-28 03:19:14 UTC

Verified with package:
libguestfs-1.36.3-1.el7.x86_64

Steps:
1. Prepare one altlinux-centaurus guest image:
altlinux-centaurus-x86_64.qcow2
2. Inspect it:
# virt-inspector -a altlinux-centaurus-x86_64.qcow2

Actual results:
<icon>iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAYAAAB
...
YACKAh7wGAAAMAtadvwYjEQmYAAAAASUVORK5CYII=</icon>

There is icon info in the xml output. So does the altlinux-simply image.
So verified.

Comment 7 errata-xmlrpc 2017-08-01 22:13:55 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2023