Bug 1435656

Summary:	Disperse: Provide description of disperse.eager-lock option.
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Sunil Kumar Acharya <sheggodu>
Component:	disperse	Assignee:	Sunil Kumar Acharya <sheggodu>
Status:	CLOSED ERRATA	QA Contact:	Nag Pavan Chilakam <nchilaka>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rhgs-3.3	CC:	amukherj, aspandey, bugs, nchilaka, rhinduja, rhs-bugs, storage-qa-internal
Target Milestone:	---	Keywords:	Triaged
Target Release:	RHGS 3.3.0
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-3.8.4-23	Doc Type:	No Doc Update
Doc Text:	undefined	Story Points:	---
Clone Of:	1327171	Environment:
Last Closed:	2017-09-21 04:35:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1327171
Bug Blocks:	1417151, 1435645

Description Sunil Kumar Acharya 2017-03-24 12:58:34 UTC

+++ This bug was initially created as a clone of Bug #1327171 +++

Description of problem:

Provide description of disperse.eager-lock option.
Similar option cluster.eager-lock for afr volume creates confusion.
Give a clear description and differentiate which option is for which type of volume. 


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-04-14 07:56:21 EDT ---

REVIEW: http://review.gluster.org/13999 (cluster/ec: Add/Modify description for eager-lock option) posted (#2) for review on master by Ashish Pandey (aspandey)

--- Additional comment from Vijay Bellur on 2016-06-03 08:16:55 EDT ---

REVIEW: http://review.gluster.org/13999 (cluster/ec: Add/Modify description for eager-lock option) posted (#3) for review on master by Ashish Pandey (aspandey)

--- Additional comment from Vijay Bellur on 2016-06-03 22:03:04 EDT ---

COMMIT: http://review.gluster.org/13999 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit b347cf85300193ab83dcfaca63c39a4907fbf730
Author: Ashish Pandey <aspandey>
Date:   Thu Apr 14 16:19:40 2016 +0530

    cluster/ec: Add/Modify description for eager-lock option
    
    This patch provides description for disperse.eager-lock
    option for disperse volume.
    
    It also modifies the description for cluster.eager-lock
    option to indicate that this option is only for replica
    volume.
    
    Change-Id: Ie73298947fcaaa6aaf825978bc2d27ceaff386d2
    BUG: 1327171
    Signed-off-by: Ashish Pandey <aspandey>
    Reviewed-on: http://review.gluster.org/13999
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Ravishankar N <ravishankar>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 2 Sunil Kumar Acharya 2017-03-24 13:32:19 UTC

Upstream Patch:
http://review.gluster.org/13999 (master)
https://review.gluster.org/16943 (3.8)
Already in 3.10.

Downstream Patch:
https://code.engineering.redhat.com/gerrit/#/c/101383

Comment 6 Nag Pavan Chilakam 2017-04-28 10:27:01 UTC

Before Fix:
(glusterfs-server-3.8.4-22.el7rhgs.x86_64)

Option: disperse.eager-lock
Default Value: on
Description: This option will enable/diable eager lock fordisperse volume 


Post fix(3.8.4-24)
Option: disperse.eager-lock
Default Value: on
Description: Enable/Disable eager lock for disperse volume. If a fop takes a lock and completes its operation, it waits for next 1 second before releasing the lock, to see if the lock can be reused for next fop from the same client. If ec finds any lock contention within 1 second it releases the lock immediately before time expires. This improves the performance of file operations.However, as it takes lock on first brick, for few operations like read, discovery of lock contention might take long time and can actually degrade the performance. If eager lock is disabled, lock will be released as soon as fop completes. 



Looking good , hence moving to verified.
However I see that we can set any junk(non boolean) value to this option, I will raise a seperate bug (not a regression)

Comment 9 errata-xmlrpc 2017-09-21 04:35:56 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2774

Comment 10 Ashish Pandey 2018-01-23 11:37:28 UTC

*** Bug 1332516 has been marked as a duplicate of this bug. ***