Bug 1436119

Summary:	the error information is not accurate when creating a vol with "--capacity -1"
Product:	Red Hat Enterprise Linux 7	Reporter:	lijuan men <lmen>
Component:	libvirt	Assignee:	Ján Tomko <jtomko>
Status:	CLOSED ERRATA	QA Contact:	jiyan <jiyan>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	7.4	CC:	dyuan, jtomko, rbalakri, xuzhang, yisun
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	libvirt-3.2.0-1.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-01 17:24:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description lijuan men 2017-03-27 08:34:38 UTC

Description of problem:
the error information is not accurate when creating a vol with "--capacity -1"

Version-Release number of selected component (if applicable):
libvirt-3.1.0-2.el7.x86_64
qemu-kvm-rhev-2.8.0-6.el7.x86_64

How reproducible:
100%

Steps to Reproduce:

[root@localhost ~]# virsh vol-create-as  default test  --capacity -1
error: Failed to create vol test
error: numerical overflow: value too large: 18446744073709551615


Actual results:
the error information is not accurate,the value I set is -1,not 18446744073709551615

Expected results:

the error information should be like this:

[root@localhost ~]# virsh vol-create-as  default test 1.0
error: Malformed size 1.0



Additional info:

Comment 2 Ján Tomko 2017-03-27 15:24:47 UTC

Pushed upstream:
commit 2da7f545a34747ae21d73ce1369a6d2055f94ea4
Author:     Ján Tomko <jtomko>
CommitDate: 2017-03-27 17:20:03 +0200

    storage: reject negative capacity
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1436119

commit df6551feb47b83c70d099b9c0d7cdf3ca2410760
Author:     Ján Tomko <jtomko>
CommitDate: 2017-03-27 17:20:03 +0200

    virsh: reject more negative numbers
    
    Be more positive and reject negative numbers where we don't
    allow them by using the virStrToLong variants with 'p'.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1436119

git describe: v3.1.0-374-gdf6551f

Comment 4 jiyan 2017-04-11 02:03:39 UTC

version:
libvirt-3.2.0-1.el7.x86_64
qemu-kvm-rhev-2.8.0-6.el7.x86_64
kernel-3.10.0-568.el7.x86_64

step:
[root@localhost ~]# virsh vol-create-as default test  --capacity -1
error: Malformed size -1

The actual result matches the expected now!

Comment 5 errata-xmlrpc 2017-08-01 17:24:15 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846

Comment 6 errata-xmlrpc 2017-08-02 00:03:43 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846